Disable external group distribution by default

Author: Cal-L

.github/workflows/auto-rc-ota-build-core.yml

@@ -142,5 +142,4 @@ jobs:
       build_commit_sha: ${{ needs.trigger-build.outputs.built_commit_sha }}
       build_version: ${{ needs.trigger-build.outputs.semantic_version }}
       build_number: ${{ needs.trigger-build.outputs.ios_version_code }}
-      distribute_external: false
     secrets: inherit

.github/workflows/build-and-upload-to-testflight.yml

@@ -20,7 +20,7 @@ on:
         type: string
         default: 'MetaMask BETA & Release Candidates'
       distribute_external:
-        description: 'Whether to distribute to external testers. Defaults to false; nightly-build.yml relies on the script default (true) so it always distributes externally.'
+        description: 'Whether to distribute to external testers. Defaults to false'
         required: false
         type: boolean
         default: false

.github/workflows/nightly-build.yml

@@ -31,7 +31,6 @@ jobs:
       source_branch: main
       environment: exp
       testflight_group: 'MetaMask BETA & Release Candidates'
-      distribute_external: true
     secrets: inherit
 
   # ── iOS rc: build + TestFlight upload (after exp for sequential versions) ─
@@ -43,7 +42,6 @@ jobs:
       source_branch: main
       environment: rc
       testflight_group: 'MetaMask BETA & Release Candidates'
-      distribute_external: false
     secrets: inherit
 
   # ── Android exp: ephemeral branch + build ──────────────────────────────

.github/workflows/runway-production-builds.yml

@@ -65,5 +65,4 @@ jobs:
       build_commit_sha: ${{ needs.build.outputs.built_commit_sha }}
       build_version: ${{ needs.build.outputs.semantic_version }}
       build_number: ${{ needs.build.outputs.ios_version_code }}
-      distribute_external: false
     secrets: inherit

.github/workflows/runway-rc-builds.yml

@@ -65,7 +65,6 @@ jobs:
       build_commit_sha: ${{ needs.build.outputs.built_commit_sha }}
       build_version: ${{ needs.build.outputs.semantic_version }}
       build_number: ${{ needs.build.outputs.ios_version_code }}
-      distribute_external: false
     secrets: inherit
 
   slack-notification:

.github/workflows/upload-to-testflight.yml

@@ -40,10 +40,10 @@ on:
         required: true
         type: string
       distribute_external:
-        description: 'Whether to distribute to external testers. Set false for nightly/internal builds to avoid expiring previous TestFlight builds.'
+        description: 'Whether to distribute to external testers. Defaults to false'
         required: false
         type: boolean
-        default: true
+        default: false
       runner_provider:
         description: Runner provider forwarded from the caller
         required: false

ios/fastlane/Fastfile

@@ -20,7 +20,7 @@ platform :ios do
     # Convert groups parameter to array (Fastlane CLI passes strings, not arrays)
     groups_param = options[:groups] || ['MetaMask BETA & Release Candidates']
     groups = groups_param.is_a?(Array) ? groups_param : [groups_param]
-    distribute_external = options[:distribute_external].nil? ? true : options[:distribute_external].to_s.downcase == 'true'
+    distribute_external = options[:distribute_external].nil? ? false : options[:distribute_external].to_s.downcase == 'true'
     notify_external_testers = distribute_external
 
     if ipa_path.nil? || ipa_path.empty?

scripts/upload-to-testflight.sh

@@ -10,7 +10,7 @@
 #   branch              - Git branch name (required)
 #   ipa_path            - Optional: Direct path to IPA file (if not provided, uses find-ipa-file.sh)
 #   testflight_group    - Optional: TestFlight external testing group name (default: MetaMask BETA & Release Candidates)
-#   distribute_external - Optional: Whether to distribute to external testers (default: true)
+#   distribute_external - Optional: Whether to distribute to external testers (default: false)
 #
 # Environment variables:
 #   IPA_PATH - IPA path (set by find-ipa-file.sh if not provided as argument)
@@ -27,7 +27,7 @@ PIPELINE_NAME="$1"
 BRANCH="$2"
 LOCAL_IPA_PATH="$3"
 TESTFLIGHT_GROUP="${4:-MetaMask BETA & Release Candidates}"
-DISTRIBUTE_EXTERNAL="${5:-true}"
+DISTRIBUTE_EXTERNAL="${5:-false}"
 
 # Get IPA path: use argument if provided, otherwise use find-ipa-file.sh
 if [ -n "$LOCAL_IPA_PATH" ]; then