Commit e78856c
authored
chore(runway): cherry-pick fix: Fix transaction type on send flow when recipient is smart account (#15813)
- fix: Fix transaction type on send flow when recipient is smart account
(#15801)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
This PR aims to fix transaction type when recipient is smart account in
send flow.
## **Related issues**
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5022
## **Manual testing steps**
1. Go to send flow
2. Pick a smart account recipient
3. Send flow should work as before (it was showing contract interaction
confirmation as in the recording)
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
https://github.com/user-attachments/assets/3a93f597-5393-45ea-b2b0-9030c5488b75
### **After**
https://github.com/user-attachments/assets/de688b3f-7680-4c40-bdc6-85a0bef2d842
## **Pre-merge author checklist**
- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[5e33202](5e33202)2 files changed
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4883 | 4883 | | |
4884 | 4884 | | |
4885 | 4885 | | |
4886 | | - | |
4887 | | - | |
4888 | | - | |
4889 | | - | |
| 4886 | + | |
| 4887 | + | |
| 4888 | + | |
| 4889 | + | |
4890 | 4890 | | |
4891 | 4891 | | |
4892 | 4892 | | |
| |||
5920 | 5920 | | |
5921 | 5921 | | |
5922 | 5922 | | |
5923 | | - | |
5924 | | - | |
5925 | | - | |
5926 | | - | |
| 5923 | + | |
| 5924 | + | |
| 5925 | + | |
| 5926 | + | |
5927 | 5927 | | |
5928 | 5928 | | |
5929 | 5929 | | |
| |||
5933 | 5933 | | |
5934 | 5934 | | |
5935 | 5935 | | |
5936 | | - | |
| 5936 | + | |
5937 | 5937 | | |
5938 | 5938 | | |
5939 | 5939 | | |
| |||
0 commit comments