Skip to content

Commit e78856c

Browse files
authored
chore(runway): cherry-pick fix: Fix transaction type on send flow when recipient is smart account (#15813)
- fix: Fix transaction type on send flow when recipient is smart account (#15801) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix transaction type when recipient is smart account in send flow. ## **Related issues** Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5022 ## **Manual testing steps** 1. Go to send flow 2. Pick a smart account recipient 3. Send flow should work as before (it was showing contract interaction confirmation as in the recording) ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/3a93f597-5393-45ea-b2b0-9030c5488b75 ### **After** https://github.com/user-attachments/assets/de688b3f-7680-4c40-bdc6-85a0bef2d842 ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [5e33202](5e33202)
2 parents d8b33c1 + f5b79dc commit e78856c

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@
230230
"@metamask/swappable-obj-proxy": "^2.1.0",
231231
"@metamask/swaps-controller": "^13.1.0",
232232
"@metamask/token-search-discovery-controller": "^3.1.0",
233-
"@metamask/transaction-controller": "55.0.0",
233+
"@metamask/transaction-controller": "^56.2.0",
234234
"@metamask/utils": "^11.2.0",
235235
"@ngraveio/bc-ur": "^1.1.6",
236236
"@noble/hashes": "^1.7.1",

yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4883,10 +4883,10 @@
48834883
eth-ens-namehash "^2.0.8"
48844884
fast-deep-equal "^3.1.3"
48854885

4886-
"@metamask/controller-utils@^11.0.0", "@metamask/controller-utils@^11.3.0", "@metamask/controller-utils@^11.5.0", "@metamask/controller-utils@^11.6.0", "@metamask/controller-utils@^11.7.0", "@metamask/controller-utils@^11.8.0":
4887-
version "11.8.0"
4888-
resolved "https://registry.yarnpkg.com/@metamask/controller-utils/-/controller-utils-11.8.0.tgz#7d573db8a2ab0ce594f92753b0bda02d18330142"
4889-
integrity sha512-FqApJXW0mnHWwnKC4HOQwf2P9fPxfiQmlLJdGWwK6hAYKQ+t7ADDw9Wf8RwVquFPzJGQbXnOcbXVBY2zAyoU5w==
4886+
"@metamask/controller-utils@^11.0.0", "@metamask/controller-utils@^11.3.0", "@metamask/controller-utils@^11.5.0", "@metamask/controller-utils@^11.6.0", "@metamask/controller-utils@^11.7.0", "@metamask/controller-utils@^11.8.0", "@metamask/controller-utils@^11.9.0":
4887+
version "11.9.0"
4888+
resolved "https://registry.yarnpkg.com/@metamask/controller-utils/-/controller-utils-11.9.0.tgz#fefe04fa53d6f0f808f756eaa079b02d256be4b1"
4889+
integrity sha512-rfOVI+wPO7WIcwsY5b/1fx44GSYIKsSgvIEUjpfF6YkI5TvbJiXKGKSHkKT1wwl0otq/k6qeM5hn3GuTOCiYwg==
48904890
dependencies:
48914891
"@ethereumjs/util" "^9.1.0"
48924892
"@metamask/eth-query" "^4.0.0"
@@ -5920,10 +5920,10 @@
59205920
"@metamask/base-controller" "^8.0.0"
59215921
"@metamask/utils" "^11.2.0"
59225922

5923-
"@metamask/transaction-controller@55.0.0":
5924-
version "55.0.0"
5925-
resolved "https://registry.yarnpkg.com/@metamask/transaction-controller/-/transaction-controller-55.0.0.tgz#f464a930ad0ad0cb33aa5371f9b5a9c2729c1c87"
5926-
integrity sha512-1Y+p7+4GiYSMwLwN27JE2NxsI3yBsDcdQLtOBYBdQKGRVmcfRUs1xINw6JvgYugLg4jVJWv2BRfEbYCGmjDx6Q==
5923+
"@metamask/transaction-controller@^56.2.0":
5924+
version "56.2.0"
5925+
resolved "https://registry.yarnpkg.com/@metamask/transaction-controller/-/transaction-controller-56.2.0.tgz#ade0392ca73b2e0972095bf0beffd417e6df4706"
5926+
integrity sha512-/GnUnQU6pBoHfpKqWH3x9iMgyiizBk3hx+PQVlf2laU8BLxwVwJYi/gT23tIOoCgGHdFYOvZdH7XtFp1tiLORA==
59275927
dependencies:
59285928
"@ethereumjs/common" "^4.4.0"
59295929
"@ethereumjs/tx" "^5.4.0"
@@ -5933,7 +5933,7 @@
59335933
"@ethersproject/providers" "^5.7.0"
59345934
"@ethersproject/wallet" "^5.7.0"
59355935
"@metamask/base-controller" "^8.0.1"
5936-
"@metamask/controller-utils" "^11.7.0"
5936+
"@metamask/controller-utils" "^11.9.0"
59375937
"@metamask/eth-query" "^4.0.0"
59385938
"@metamask/metamask-eth-abis" "^3.1.1"
59395939
"@metamask/nonce-tracker" "^6.0.0"

0 commit comments

Comments
 (0)