feat: replace getTransactionController instance with messenger mock

Instead of passing wallet.getInstance('TransactionController') through
initialization.ts into the publish hooks, create a messenger-backed mock
inside getTransactionControllerInstanceOptions — following the same
pattern as getSmartTransactionsController.

- Remove getTransactionController param from
  GetTransactionControllerInstanceOptionsRequest
- Add private getTransactionController(messenger) that routes state,
  getNonceLock, isAtomicBatchSupported, and
  approveTransactionsWithSameNonce through the init messenger
- Expose the three new TC actions on the init messenger
  (getNonceLock, isAtomicBatchSupported, approveTransactionsWithSameNonce)

Author: matthewwalsh0

app/core/Engine/wallet-init/initialization.ts

@@ -54,8 +54,6 @@ export function initializeWallet({
       storageService: getStorageServiceInstanceOptions(),
       transactionController: getTransactionControllerInstanceOptions({
         getState,
-        getTransactionController: () =>
-          wallet.getInstance('TransactionController'),
         initMessenger: transactionControllerInitMessenger,
       }),
     },

app/core/Engine/wallet-init/instance-options/transaction-controller.test.ts

@@ -92,7 +92,6 @@ describe('TransactionController wallet instance options', () => {
 
     return getTransactionControllerInstanceOptions({
       getState,
-      getTransactionController: jest.fn(),
       initMessenger,
     });
   }

app/core/Engine/wallet-init/instance-options/transaction-controller.ts

@@ -39,7 +39,6 @@ type TransactionControllerInstanceOptions = NonNullable<
 
 type GetTransactionControllerInstanceOptionsRequest = {
   getState: () => RootState;
-  getTransactionController: () => TransactionController;
   initMessenger: TransactionControllerInitMessenger;
 };
 
@@ -55,21 +54,20 @@ type SetupTransactionControllerListenersRequest = {
  *
  * @param request - The request bag.
  * @param request.getState - Returns the current Redux root state.
- * @param request.getTransactionController - Lazily returns the constructed
- * `TransactionController` instance (used by publish hooks).
  * @param request.initMessenger - The TransactionController init messenger.
  * @returns The TransactionController instance options.
  */
 export function getTransactionControllerInstanceOptions({
   getState,
-  getTransactionController,
   initMessenger,
 }: GetTransactionControllerInstanceOptionsRequest): TransactionControllerInstanceOptions {
+  const transactionController = getTransactionController(initMessenger);
+  
   return {
     disableSwaps: true,
     hooks: getTransactionControllerHooks({
       getState,
-      getTransactionController,
+      getTransactionController: () => transactionController,
       initMessenger,
     }),
     isAutomaticGasFeeUpdateEnabled,
@@ -221,6 +219,42 @@ function getSmartTransactionsController(
   } as unknown as SmartTransactionsController;
 }
 
+/**
+ * Creates a messenger-based mock of `TransactionController` for use inside
+ * the publish hooks.  All calls are routed through the init messenger so that
+ * no real controller instance is passed around.
+ *
+ * Follows the same pattern as `getSmartTransactionsController` above.
+ *
+ * @param messenger - The TransactionController init messenger.
+ * @returns A TransactionController-shaped object backed by messenger actions.
+ */
+function getTransactionController(
+  messenger: TransactionControllerInitMessenger,
+): TransactionController {
+  return {
+    get state() {
+      return messenger.call('TransactionController:getState');
+    },
+    getNonceLock: (
+      ...args: Parameters<TransactionController['getNonceLock']>
+    ) => messenger.call('TransactionController:getNonceLock', ...args),
+    isAtomicBatchSupported: (
+      ...args: Parameters<TransactionController['isAtomicBatchSupported']>
+    ) =>
+      messenger.call('TransactionController:isAtomicBatchSupported', ...args),
+    approveTransactionsWithSameNonce: (
+      ...args: Parameters<
+        TransactionController['approveTransactionsWithSameNonce']
+      >
+    ) =>
+      messenger.call(
+        'TransactionController:approveTransactionsWithSameNonce',
+        ...args,
+      ),
+  } as unknown as TransactionController;
+}
+
 async function isEIP7702GasFeeTokensEnabled(
   {
     getState,

app/core/Engine/wallet-init/messengers/transaction-controller-messenger.ts

@@ -14,8 +14,11 @@ import {
 import {
   TransactionControllerAddTransactionAction,
   TransactionControllerAddTransactionBatchAction,
+  TransactionControllerApproveTransactionsWithSameNonceAction,
   TransactionControllerEstimateGasBatchAction,
+  TransactionControllerGetNonceLockAction,
   TransactionControllerGetStateAction,
+  TransactionControllerIsAtomicBatchSupportedAction,
   TransactionControllerStateChangeEvent,
   TransactionControllerTransactionApprovedEvent,
   TransactionControllerTransactionConfirmedEvent,
@@ -90,8 +93,11 @@ export type TransactionControllerInitMessengerActions =
   | SmartTransactionsControllerSubmitSignedTransactionsAction
   | TransactionControllerAddTransactionAction
   | TransactionControllerAddTransactionBatchAction
+  | TransactionControllerApproveTransactionsWithSameNonceAction
   | TransactionControllerEstimateGasBatchAction
+  | TransactionControllerGetNonceLockAction
   | TransactionControllerGetStateAction
+  | TransactionControllerIsAtomicBatchSupportedAction
   | TransactionControllerUpdateTransactionAction
   | TransactionPayControllerActions
   | AnalyticsControllerActions
@@ -158,8 +164,11 @@ export function getTransactionControllerInitMessenger(
       'SmartTransactionsController:submitSignedTransactions',
       'TransactionController:addTransaction',
       'TransactionController:addTransactionBatch',
+      'TransactionController:approveTransactionsWithSameNonce',
       'TransactionController:estimateGasBatch',
+      'TransactionController:getNonceLock',
       'TransactionController:getState',
+      'TransactionController:isAtomicBatchSupported',
       'TransactionController:updateTransaction',
       'TransactionPayController:getAmountData',
       'TransactionPayController:getDelegationTransaction',