Refine ramps circuit breaker user message

Author: saustrie-consensys

app/components/UI/Ramp/hooks/useRampsCountries.test.ts

@@ -138,7 +138,7 @@ describe('useRampsCountries', () => {
         wrapper: wrapper(store),
       });
 
-      expect(result.current.error).toBe('fiat_on_ramp.payment_error');
+      expect(result.current.error).toBe('fiat_on_ramp.circuit_breaker_open');
     });
   });
 });

app/components/UI/Ramp/hooks/useRampsPaymentMethods.test.ts

@@ -251,7 +251,7 @@ describe('useRampsPaymentMethods', () => {
       expect(result.current.status).toBe('error');
     });
 
-    expect(result.current.error).toBe('fiat_on_ramp.payment_error');
+    expect(result.current.error).toBe('fiat_on_ramp.circuit_breaker_open');
   });
 
   it('calls Engine.context.RampsController.setSelectedPaymentMethod with full payment method object', () => {

app/components/UI/Ramp/hooks/useRampsProviders.test.ts

@@ -220,7 +220,7 @@ describe('useRampsProviders', () => {
         wrapper: wrapper(store),
       });
 
-      expect(result.current.error).toBe('fiat_on_ramp.payment_error');
+      expect(result.current.error).toBe('fiat_on_ramp.circuit_breaker_open');
     });
   });
 

app/components/UI/Ramp/hooks/useRampsTokens.test.ts

@@ -135,7 +135,7 @@ describe('useRampsTokens', () => {
         wrapper: wrapper(store),
       });
 
-      expect(result.current.error).toBe('fiat_on_ramp.payment_error');
+      expect(result.current.error).toBe('fiat_on_ramp.circuit_breaker_open');
     });
   });
 

app/components/UI/Ramp/utils/parseUserFacingError.test.ts

@@ -1,3 +1,10 @@
+jest.mock('../../../../../locales/i18n', () => ({
+  strings: (key: string) =>
+    key === 'fiat_on_ramp.circuit_breaker_open'
+      ? 'This service is temporarily unavailable. Please try again in about 30 minutes.'
+      : key,
+}));
+
 import { parseUserFacingError } from './parseUserFacingError';
 
 const FALLBACK = 'Something went wrong';
@@ -79,7 +86,9 @@ describe('parseUserFacingError', () => {
       { errorKey: 'CIRCUIT_BREAKER_OPEN' },
     );
 
-    expect(parseUserFacingError(circuitBreakerError, FALLBACK)).toBe(FALLBACK);
+    expect(parseUserFacingError(circuitBreakerError, FALLBACK)).toBe(
+      'This service is temporarily unavailable. Please try again in about 30 minutes.',
+    );
   });
 
   it('returns fallback for resource-like circuit breaker errors', () => {
@@ -91,7 +100,9 @@ describe('parseUserFacingError', () => {
         },
         FALLBACK,
       ),
-    ).toBe(FALLBACK);
+    ).toBe(
+      'This service is temporarily unavailable. Please try again in about 30 minutes.',
+    );
   });
 
   it('handles JSON body where error.message is empty', () => {

app/components/UI/Ramp/utils/parseUserFacingError.ts

@@ -1,4 +1,7 @@
+import { strings } from '../../../../../locales/i18n';
+
 const CIRCUIT_BREAKER_OPEN_ERROR_KEY = 'CIRCUIT_BREAKER_OPEN';
+const CIRCUIT_BREAKER_OPEN_MESSAGE_KEY = 'fiat_on_ramp.circuit_breaker_open';
 
 function getErrorKey(error: unknown): string | null {
   if (typeof error !== 'object' || error === null || !('errorKey' in error)) {
@@ -40,7 +43,7 @@ function getRawMessage(error: unknown): string {
  */
 export function parseUserFacingError(error: unknown, fallback: string): string {
   if (getErrorKey(error) === CIRCUIT_BREAKER_OPEN_ERROR_KEY) {
-    return fallback;
+    return strings(CIRCUIT_BREAKER_OPEN_MESSAGE_KEY);
   }
 
   const rawMessage = getRawMessage(error);

locales/languages/en.json

@@ -5245,6 +5245,7 @@
     "pay_with": "Pay with",
     "buying_via": "Buying via {{providerName}}.",
     "change_provider": "Change provider.",
+    "circuit_breaker_open": "This service is temporarily unavailable. Please try again in about 30 minutes.",
     "payment_error": "Something went wrong. Please try again.",
     "no_payment_methods_available": "No payment methods are available.",
     "error_fetching_quotes": "Something went wrong. Please try again.",