Skip to content

Commit ed27aa0

Browse files
authored
fix(ramps): check for providers before checking array length (#27566)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fixes a bootstrap bug when providers are not available. <img width="1206" height="2622" alt="Simulator Screenshot - mm-green - 2026-03-17 at 14 35 05" src="https://github.com/user-attachments/assets/2785ed1e-b7f6-4e8d-9e7b-6c1f74cf8559" /> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > <sup>[Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) is generating a summary for commit 32f2796. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 739788f commit ed27aa0

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

app/components/UI/Ramp/hooks/useRampsProviders.test.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,5 +270,19 @@ describe('useRampsProviders', () => {
270270

271271
expect(mockDeterminePreferredProvider).not.toHaveBeenCalled();
272272
});
273+
274+
it('does not call determinePreferredProvider when providers is undefined', () => {
275+
const store = createMockStore({ data: undefined });
276+
mockDeterminePreferredProvider.mockClear();
277+
278+
renderHook(() => useRampsProviders(), {
279+
wrapper: wrapper(store),
280+
});
281+
282+
expect(mockDeterminePreferredProvider).not.toHaveBeenCalled();
283+
expect(
284+
Engine.context.RampsController.setSelectedProvider,
285+
).not.toHaveBeenCalled();
286+
});
273287
});
274288
});

app/components/UI/Ramp/hooks/useRampsProviders.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export function useRampsProviders(): UseRampsProvidersResult {
7272
);
7373

7474
useEffect(() => {
75-
if (providers.length > 0 && !selectedProvider) {
75+
if (providers && providers.length > 0 && !selectedProvider) {
7676
setSelectedProvider(
7777
determinePreferredProvider(completedOrders, providers),
7878
);

0 commit comments

Comments
 (0)