Skip to content

Commit ee9c23b

Browse files
VGR-GITclaude
andcommitted
fix(rewards): default isDismissed to true when subscription or campaign id is missing
Co-authored-by: VGR-GIT <vangulckrik@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 5c5f2fe commit ee9c23b

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

app/components/UI/Rewards/hooks/useOndoCampaignEndedOutcomeToast.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ export function useOndoCampaignEndedOutcomeToast(
3636
const toastKey =
3737
subscriptionId && campaignId ? `${subscriptionId}:${campaignId}` : '';
3838
const isDismissed = useSelector(
39-
selectIsCampaignOutcomeToastDismissed(
40-
subscriptionId ?? '',
41-
campaignId ?? '',
42-
),
39+
selectIsCampaignOutcomeToastDismissed(subscriptionId ?? undefined, campaignId),
4340
);
4441

4542
const hasShownRef = useRef(false);

app/reducers/rewards/selectors.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -307,10 +307,13 @@ export const selectOndoCampaignParticipantOutcomeById =
307307
: null;
308308

309309
export const selectIsCampaignOutcomeToastDismissed =
310-
(subscriptionId: string, campaignId: string) => (state: RootState) =>
311-
state.rewards.dismissedCampaignOutcomeToasts[
312-
`${subscriptionId}:${campaignId}`
313-
] === true;
310+
(subscriptionId: string | undefined, campaignId: string | undefined) =>
311+
(state: RootState) =>
312+
!subscriptionId || !campaignId
313+
? true
314+
: state.rewards.dismissedCampaignOutcomeToasts[
315+
`${subscriptionId}:${campaignId}`
316+
] === true;
314317

315318
export const selectPendingDeeplink = (state: RootState) =>
316319
state.rewards.pendingDeeplink;

0 commit comments

Comments
 (0)