Update Snap settings tests

Author: Mrtenz

app/components/Views/Snaps/SnapSettings/test/SnapSettings.test.tsx

@@ -26,6 +26,7 @@ import {
   KEYRING_SNAP_REMOVAL_WARNING_CONTINUE,
   KEYRING_SNAP_REMOVAL_WARNING_TEXT_INPUT,
 } from '../../KeyringSnapRemovalWarning/KeyringSnapRemovalWarning.constants';
+import { createMockRouteMessenger } from '../../../../../util/test/mock-route-messenger';
 
 const MOCK_ACCOUNTS_CONTROLLER_STATE = createMockAccountsControllerState([
   MOCK_ADDRESS_1,
@@ -215,9 +216,6 @@ jest.mock('../../../../../core/Engine', () => {
     }),
     removeAccount: jest.fn(),
     context: {
-      SnapController: {
-        removeSnap: jest.fn(),
-      },
       KeyringController: {
         state: {
           keyrings: [
@@ -248,11 +246,16 @@ describe('SnapSettings with non keyring snap', () => {
   });
 
   it('renders correctly', () => {
+    const routeMessenger = createMockRouteMessenger({
+      'SnapController:removeSnap': jest.fn(),
+    });
+
     const { getAllByTestId, getByTestId } = renderWithProvider(
       <SnapSettings />,
       {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         state: initialState as any,
+        routeMessenger,
       },
     );
 
@@ -268,14 +271,22 @@ describe('SnapSettings with non keyring snap', () => {
   });
 
   it('remove snap and goes back when Remove button is pressed', async () => {
+    const routeMessenger = createMockRouteMessenger({
+      'SnapController:removeSnap': jest.fn(),
+    });
+
+    jest.spyOn(routeMessenger, 'call');
+
     const { getByTestId } = renderWithProvider(<SnapSettings />, {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
       state: initialState as any,
+      routeMessenger,
     });
 
     const removeButton = getByTestId(SNAP_SETTINGS_REMOVE_BUTTON);
     fireEvent(removeButton, 'onPress');
-    expect(Engine.context.SnapController.removeSnap).toHaveBeenCalledWith(
+    expect(routeMessenger.call).toHaveBeenCalledWith(
+      'SnapController:removeSnap',
       'npm:@chainsafe/filsnap',
     );
     await waitFor(() => {
@@ -390,9 +401,14 @@ describe('SnapSettings with keyring snap', () => {
   };
 
   it('renders KeyringSnapRemovalWarning when removing a keyring snap', async () => {
+    const routeMessenger = createMockRouteMessenger({
+      'SnapController:removeSnap': jest.fn(),
+    });
+
     const { getByTestId } = renderWithProvider(<SnapSettings />, {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
       state: initialStateWithKeyringSnap as any,
+      routeMessenger,
     });
 
     // Needed to allow for useEffect to run
@@ -406,10 +422,17 @@ describe('SnapSettings with keyring snap', () => {
     });
   });
 
-  it('calls Engine.context.SnapController and Engine.removeAccount when removing a keyring snap with accounts', async () => {
+  it('calls `SnapController:removeSnap` when removing a keyring snap with accounts', async () => {
+    const routeMessenger = createMockRouteMessenger({
+      'SnapController:removeSnap': jest.fn(),
+    });
+
+    jest.spyOn(routeMessenger, 'call');
+
     const { getByTestId } = renderWithProvider(<SnapSettings />, {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
       state: initialStateWithKeyringSnap as any,
+      routeMessenger,
     });
 
     // Needed to allow for useEffect to run
@@ -439,7 +462,8 @@ describe('SnapSettings with keyring snap', () => {
 
     // Step 5: Verify that the removal functions are called
     await waitFor(() => {
-      expect(Engine.context.SnapController.removeSnap).toHaveBeenCalledWith(
+      expect(routeMessenger.call).toHaveBeenCalledWith(
+        'SnapController:removeSnap',
         mockKeyringSnapId,
       );
       expect(Engine.removeAccount).toHaveBeenCalledTimes(2);

app/util/test/renderWithProvider.tsx

@@ -23,6 +23,8 @@ import {
   RouteMessengerContext,
   LegacyRouteMessengerProvider,
 } from '../../contexts/route-messenger';
+import { RouteMessenger } from '../../messengers/route-messenger';
+import { UIMessenger } from '../../messengers/ui-messenger';
 
 // DeepPartial is a generic type that recursively makes all properties of a given type T optional
 export type DeepPartial<T> = T extends (...args: unknown[]) => unknown
@@ -36,20 +38,27 @@ export type DeepPartial<T> = T extends (...args: unknown[]) => unknown
         { [K in keyof T]?: DeepPartial<T[K]> }
       : // Otherwise, return T or undefined.
         T | undefined;
+
 export interface ProviderValues {
   state?: DeepPartial<RootState>;
   theme?: Theme;
+  uiMessenger?: UIMessenger;
+  routeMessenger?: RouteMessenger;
 }
 
 export default function renderWithProvider(
   component: React.ReactElement,
   providerValues?: ProviderValues,
   includeNavigationContainer = true,
   includeFeatureFlagOverrideProvider = true,
-  uiMessenger = createMockUIMessenger(),
-  routeMessenger = null,
 ) {
-  const { state = {}, theme = mockTheme } = providerValues ?? {};
+  const {
+    state = {},
+    theme = mockTheme,
+    uiMessenger = createMockUIMessenger(),
+    routeMessenger = null,
+  } = providerValues ?? {};
+
   const store = configureStore(state);
   // eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires
   require('../../store')._updateMockState(state);