Skip to content

Commit f520f7e

Browse files
georgewrmarshallgeorgewrmarshall
authored
chore(fonts): remove remaining Geist-Bold references (#28425)
## **Description** Starting cleanup PR for semibold migration by removing remaining static `Geist-Bold`/`Geist-BoldItalic` references and deleting obsolete bold font assets. This PR: - Replaces app-level static `Geist-Bold` usages with `Geist-SemiBold` - Updates Veriff branding font mapping to use semibold for the `bold` slot - Removes `Geist-Bold.otf` and `Geist-BoldItalic.otf` from Expo font config and native asset manifests - Removes iOS plist/Xcode registrations for the deleted bold font files - Deletes obsolete font files from `app/fonts` ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: #28387 Related: - #28363 - https://consensyssoftware.atlassian.net/browse/DSYS-664 ## **Manual testing steps** ```gherkin Feature: Semibold migration cleanup Scenario: user views screens with emphasized text after bold asset removal Given the app is running on this branch When user opens Review Modal, malicious dapp warning connect flow, and Card Verify Identity flow Then emphasized text renders with semibold typography And no missing-font fallback appears on iOS or Android ``` ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Medium risk because it removes bundled font assets and native registrations; any missed `Geist-Bold`/`Geist-BoldItalic` references could cause font fallback or missing-font issues at runtime. > > **Overview** > Completes the semibold migration cleanup by replacing remaining UI usages of `Geist-Bold` with `Geist-SemiBold` (including Veriff branding in `VerifyIdentity`, the malicious dapp connect button label, and Review Modal header text). > > Removes the `Geist-Bold.otf` and `Geist-BoldItalic.otf` assets from Expo font configuration and both Android/iOS asset manifests, and drops the corresponding iOS Xcode project and `Info.plist` font registrations so the bold files are no longer bundled. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 89f069d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 6b87906 commit f520f7e

12 files changed

Lines changed: 4 additions & 36 deletions

File tree

‎android/link-assets-manifest.json‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
{
22
"migIndex": 1,
33
"data": [
4-
{
5-
"path": "app/fonts/Geist-BoldItalic.otf",
6-
"sha1": "98112360bd15168cd0416f7457d2cf930bdd9194"
7-
},
8-
{
9-
"path": "app/fonts/Geist-Bold.otf",
10-
"sha1": "53d4deff787adeb561e69bfa4b28375710f4686f"
11-
},
124
{
135
"path": "app/fonts/Geist-SemiBoldItalic.otf",
146
"sha1": "bbbda4921114ab99f8af88f06fd0cbe54c3c2d04"

‎app.config.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,9 @@ module.exports = {
7171
'./app/fonts/Geist-Regular.otf',
7272
'./app/fonts/Geist-Medium.otf',
7373
'./app/fonts/Geist-SemiBold.otf',
74-
'./app/fonts/Geist-Bold.otf',
7574
'./app/fonts/Geist-RegularItalic.otf',
7675
'./app/fonts/Geist-MediumItalic.otf',
7776
'./app/fonts/Geist-SemiBoldItalic.otf',
78-
'./app/fonts/Geist-BoldItalic.otf',
7977
'./app/fonts/MMSans-Regular.otf',
8078
'./app/fonts/MMSans-Medium.otf',
8179
'./app/fonts/MMSans-Bold.otf',

‎app/components/UI/Card/components/Onboarding/VerifyIdentity.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ const VerifyIdentity = () => {
5656
iOSFont: {
5757
regular: 'Geist-Regular',
5858
medium: 'Geist-Medium',
59-
bold: 'Geist-Bold',
59+
bold: 'Geist-SemiBold',
6060
},
6161
androidFont: {
6262
regular: 'Geist-Regular',
6363
medium: 'Geist-Medium',
64-
bold: 'Geist-Bold',
64+
bold: 'Geist-SemiBold',
6565
},
6666
}),
6767
[colors],

‎app/components/UI/PermissionsSummary/MaliciousDappIndicators.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const styles = StyleSheet.create({
2121
},
2222
buttonText: {
2323
fontSize: 14,
24-
fontFamily: 'Geist-Bold',
24+
fontFamily: 'Geist-SemiBold',
2525
textAlign: 'center',
2626
},
2727
});

‎app/components/UI/ReviewModal/styles.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const createStyles = (colors: any) =>
2929
questionLabel: {
3030
fontSize: 18,
3131
paddingHorizontal: 30,
32-
fontFamily: 'Geist-Bold',
32+
fontFamily: 'Geist-SemiBold',
3333
textAlign: 'center',
3434
color: colors.text.default,
3535
lineHeight: 26,

‎app/fonts/Geist-Bold.otf‎

-130 KB
Binary file not shown.

‎app/fonts/Geist-BoldItalic.otf‎

-131 KB
Binary file not shown.

‎ios/MetaMask.xcodeproj/project.pbxproj‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
7696E77F73B5ADD7EE8190E0 /* ExpoModulesProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = E7EEA32C976A46B991D55FD4 /* ExpoModulesProvider.swift */; };
5656
8C3986ED969040AEBC7A3856 /* MMPoly-Regular.otf in Resources */ = {isa = PBXBuildFile; fileRef = F10E7EBF946A4F6D8E229143 /* MMPoly-Regular.otf */; };
5757
8DE564ACA9934796B5E7B1EB /* MMSans-Regular.otf in Resources */ = {isa = PBXBuildFile; fileRef = F3C919D8F42C47389FF643E7 /* MMSans-Regular.otf */; };
58-
98DA5101D5C341F5A5412C04 /* Geist-Bold.otf in Resources */ = {isa = PBXBuildFile; fileRef = DCB5FECA5557491AB06DBCBE /* Geist-Bold.otf */; };
5958
9D9E53F67A884FDEBE9A4D3C /* Geist-RegularItalic.otf in Resources */ = {isa = PBXBuildFile; fileRef = 978781C44CFB4434873EDB69 /* Geist-RegularItalic.otf */; };
6059
A1987088D4835E5FCCABC418 /* ExpoModulesProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = 683865D794CE6007E46CAD3A /* ExpoModulesProvider.swift */; };
6160
A1F5C74197AA4BB4B2F9C001 /* Geist-SemiBold.otf in Resources */ = {isa = PBXBuildFile; fileRef = A1F5C74197AA4BB4B2F9C011 /* Geist-SemiBold.otf */; };
@@ -80,7 +79,6 @@
8079
B339FF23289ABD70001B89FB /* branch.json in Resources */ = {isa = PBXBuildFile; fileRef = FE3C9A2458A1416290DEDAD4 /* branch.json */; };
8180
B339FF32289ABD70001B89FB /* Branch.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 153F84C92319B8DB00C19B63 /* Branch.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
8281
B339FF3C289ABF2C001B89FB /* MetaMask-QA-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = B339FEA72899852C001B89FB /* MetaMask-QA-Info.plist */; };
83-
B8B9B88C931A45F59B13181F /* Geist-BoldItalic.otf in Resources */ = {isa = PBXBuildFile; fileRef = 5914F547268E4F7BB337A3DF /* Geist-BoldItalic.otf */; };
8482
BAB8A7C7328F48B6AC38DCE9 /* Geist-Regular.otf in Resources */ = {isa = PBXBuildFile; fileRef = B848D40B87744D32949BDC25 /* Geist-Regular.otf */; };
8583
C7B6D2EC4EBB469F9E0658BE /* MMSans-Bold.otf in Resources */ = {isa = PBXBuildFile; fileRef = D3350113F0764105B1E60002 /* MMSans-Bold.otf */; };
8684
C8424AE42CCC01F900F0BEB7 /* GoogleService-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = C8424AE32CCC01F900F0BEB7 /* GoogleService-Info.plist */; };
@@ -212,7 +210,6 @@
212210
4C81CC9BCD86AC7F96BA8CAD /* Pods-MetaMask.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-MetaMask.debug.xcconfig"; path = "Target Support Files/Pods-MetaMask/Pods-MetaMask.debug.xcconfig"; sourceTree = "<group>"; };
213211
51AB7231D0E692F5EF71FACB /* Pods-MetaMask-QA.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-MetaMask-QA.debug.xcconfig"; path = "Target Support Files/Pods-MetaMask-QA/Pods-MetaMask-QA.debug.xcconfig"; sourceTree = "<group>"; };
214212
57C103F40F394637B5A886FC /* FontAwesome5_Brands.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = FontAwesome5_Brands.ttf; path = "../node_modules/react-native-vector-icons/Fonts/FontAwesome5_Brands.ttf"; sourceTree = "<group>"; };
215-
5914F547268E4F7BB337A3DF /* Geist-BoldItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "Geist-BoldItalic.otf"; path = "../app/fonts/Geist-BoldItalic.otf"; sourceTree = "<group>"; };
216213
5E32A09A7BDC431FA403BA73 /* FontAwesome.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = FontAwesome.ttf; path = "../node_modules/react-native-vector-icons/Fonts/FontAwesome.ttf"; sourceTree = "<group>"; };
217214
650F2B9724DC5FEB00C3B9C4 /* RCTAesForked.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = RCTAesForked.xcodeproj; path = "../node_modules/react-native-aes-crypto-forked/ios/RCTAesForked.xcodeproj"; sourceTree = "<group>"; };
218215
654378AE243E2ADB00571B9C /* MetaMask-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "MetaMask-Bridging-Header.h"; sourceTree = "<group>"; };
@@ -246,7 +243,6 @@
246243
D0CBAE789660472DB719C765 /* libLottie.a */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = archive.ar; path = libLottie.a; sourceTree = "<group>"; };
247244
D2632307C64595BE1B8ABEAF /* libPods-MetaMask.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-MetaMask.a"; sourceTree = BUILT_PRODUCTS_DIR; };
248245
D3350113F0764105B1E60002 /* MMSans-Bold.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "MMSans-Bold.otf"; path = "../app/fonts/MMSans-Bold.otf"; sourceTree = "<group>"; };
249-
DCB5FECA5557491AB06DBCBE /* Geist-Bold.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "Geist-Bold.otf"; path = "../app/fonts/Geist-Bold.otf"; sourceTree = "<group>"; };
250246
E4B580712E32F462008165E1 /* Expo.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Expo.plist; sourceTree = "<group>"; };
251247
E7EEA32C976A46B991D55FD4 /* ExpoModulesProvider.swift */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.swift; name = ExpoModulesProvider.swift; path = "Pods/Target Support Files/Pods-MetaMask-QA/ExpoModulesProvider.swift"; sourceTree = "<group>"; };
252248
E83DB5392BBDB14700536063 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; name = PrivacyInfo.xcprivacy; path = MetaMask/PrivacyInfo.xcprivacy; sourceTree = SOURCE_ROOT; };
@@ -431,8 +427,6 @@
431427
D3350113F0764105B1E60002 /* MMSans-Bold.otf */,
432428
4A64F1985EEA45C0B027E517 /* MMSans-Medium.otf */,
433429
F3C919D8F42C47389FF643E7 /* MMSans-Regular.otf */,
434-
5914F547268E4F7BB337A3DF /* Geist-BoldItalic.otf */,
435-
DCB5FECA5557491AB06DBCBE /* Geist-Bold.otf */,
436430
A1F5C74197AA4BB4B2F9C012 /* Geist-SemiBoldItalic.otf */,
437431
A1F5C74197AA4BB4B2F9C011 /* Geist-SemiBold.otf */,
438432
6E7939D848B5467AA6602966 /* Geist-MediumItalic.otf */,
@@ -720,8 +714,6 @@
720714
C7B6D2EC4EBB469F9E0658BE /* MMSans-Bold.otf in Resources */,
721715
3F123FD0EA9146FEBC864879 /* MMSans-Medium.otf in Resources */,
722716
8DE564ACA9934796B5E7B1EB /* MMSans-Regular.otf in Resources */,
723-
B8B9B88C931A45F59B13181F /* Geist-BoldItalic.otf in Resources */,
724-
98DA5101D5C341F5A5412C04 /* Geist-Bold.otf in Resources */,
725717
A1F5C74197AA4BB4B2F9C002 /* Geist-SemiBoldItalic.otf in Resources */,
726718
A1F5C74197AA4BB4B2F9C001 /* Geist-SemiBold.otf in Resources */,
727719
09D9851F119C43FBB54ED59C /* Geist-MediumItalic.otf in Resources */,

‎ios/MetaMask/Info.plist‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,6 @@
9595
<string>MMSans-Bold.otf</string>
9696
<string>MMSans-Medium.otf</string>
9797
<string>MMSans-Regular.otf</string>
98-
<string>Geist-BoldItalic.otf</string>
99-
<string>Geist-Bold.otf</string>
10098
<string>Geist-SemiBoldItalic.otf</string>
10199
<string>Geist-SemiBold.otf</string>
102100
<string>Geist-MediumItalic.otf</string>

‎ios/MetaMask/MetaMask-Flask-Info.plist‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,6 @@
9595
<string>MMSans-Bold.otf</string>
9696
<string>MMSans-Medium.otf</string>
9797
<string>MMSans-Regular.otf</string>
98-
<string>Geist-BoldItalic.otf</string>
99-
<string>Geist-Bold.otf</string>
10098
<string>Geist-SemiBoldItalic.otf</string>
10199
<string>Geist-SemiBold.otf</string>
102100
<string>Geist-MediumItalic.otf</string>

0 commit comments

Comments
 (0)