Commit fad4a12
authored
refactor(analytics): migrate Batch 3-17: mobile-platform (#26679)
## **Description**
Phase 3 analytics migration (Batch 3-17): migrate Sample Feature's
components and hooks from `useMetrics`/`MetricsEventBuilder` to the new
`useAnalytics`/`AnalyticsEventBuilder` analytics system.
**Reason**: Deprecate MetaMetrics in favour of the shared analytics
utility and AnalyticsController.
**Changes**: `SamplePetNamesForm`, `SampleCounterPane`, and
`SampleFeatureDevSettingsEntryPoint` now use `useAnalytics()` from
`app/components/hooks/useAnalytics/useAnalytics` and
`createEventBuilder` from the hook instead of `useMetrics()` and
`MetricsEventBuilder`; test mocks updated to mock the `useAnalytics`
hook with a chainable builder instead of `useMetrics`.
## **Changelog**
CHANGELOG entry: null
## **Related issues**
Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-302 (Batch
3-17)
## **Manual testing steps**
```gherkin
Feature: Sample Feature analytics
Scenario: user triggers a Sample Feature flow event
Given app is open and user is in a Sample Feature flow
When user performs an action that triggers analytics (e.g. increment counter, add pet name, navigate to sample feature)
Then the event is tracked on Mixpanel
```
## **Screenshots/Recordings**
N/A – analytics migration, no UI change.
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk: this is a refactor of analytics event building/tracking in a
non-production sample feature, with corresponding unit test updates.
Main risk is mis-tracked or missing events due to the new
builder/mocking semantics.
>
> **Overview**
> Updates SampleFeature event tracking to use `useAnalytics()` and its
`createEventBuilder` instead of `useMetrics()`/`MetricsEventBuilder` in
`SampleCounterPane`, `SamplePetNamesForm`, and the dev-settings entry
point.
>
> Adjusts analytics event definitions (`analytics/events.ts`) and
rewrites unit tests to mock/verify the new `useAnalytics` hook and
builder chaining, plus updates SampleFeature docs/e2e docs to refer to
**Analytics** (not MetaMetrics).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
2dce2e4. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 8a48496 commit fad4a12
8 files changed
Lines changed: 45 additions & 109 deletions
File tree
- app/features/SampleFeature
- analytics
- components/views
- SampleCounterPane
- SampleFeatureDevSettingsEntryPoint
- SamplePetNames
- e2e
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | | - | |
| 211 | + | |
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
218 | | - | |
| 217 | + | |
219 | 218 | | |
220 | 219 | | |
221 | 220 | | |
| |||
424 | 423 | | |
425 | 424 | | |
426 | 425 | | |
427 | | - | |
| 426 | + | |
428 | 427 | | |
429 | 428 | | |
430 | 429 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
Lines changed: 5 additions & 40 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | | - | |
| 7 | + | |
9 | 8 | | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | 9 | | |
15 | 10 | | |
16 | 11 | | |
17 | 12 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | 13 | | |
23 | 14 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | 15 | | |
29 | 16 | | |
30 | 17 | | |
| |||
33 | 20 | | |
34 | 21 | | |
35 | 22 | | |
36 | | - | |
| 23 | + | |
37 | 24 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | 25 | | |
47 | 26 | | |
48 | 27 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | 28 | | |
63 | 29 | | |
64 | 30 | | |
| |||
107 | 73 | | |
108 | 74 | | |
109 | 75 | | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
114 | 79 | | |
115 | 80 | | |
116 | 81 | | |
| |||
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| |||
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
46 | | - | |
| 45 | + | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
50 | | - | |
51 | | - | |
52 | | - | |
| 49 | + | |
53 | 50 | | |
54 | 51 | | |
55 | 52 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
Lines changed: 21 additions & 39 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | | - | |
| 14 | + | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
25 | | - | |
26 | 24 | | |
27 | 25 | | |
28 | 26 | | |
29 | 27 | | |
30 | | - | |
31 | | - | |
32 | 28 | | |
33 | 29 | | |
| 30 | + | |
| 31 | + | |
34 | 32 | | |
35 | 33 | | |
36 | 34 | | |
37 | 35 | | |
38 | | - | |
39 | | - | |
40 | 36 | | |
41 | 37 | | |
42 | 38 | | |
43 | 39 | | |
44 | 40 | | |
45 | | - | |
46 | 41 | | |
47 | | - | |
48 | 42 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | 43 | | |
64 | 44 | | |
65 | 45 | | |
| |||
130 | 110 | | |
131 | 111 | | |
132 | 112 | | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
141 | 116 | | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
142 | 123 | | |
143 | 124 | | |
144 | 125 | | |
| |||
246 | 227 | | |
247 | 228 | | |
248 | 229 | | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
257 | 233 | | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
258 | 240 | | |
259 | 241 | | |
260 | 242 | | |
Lines changed: 5 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| |||
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | | - | |
| 59 | + | |
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
| |||
71 | 70 | | |
72 | 71 | | |
73 | 72 | | |
74 | | - | |
75 | | - | |
76 | | - | |
| 73 | + | |
77 | 74 | | |
78 | 75 | | |
79 | 76 | | |
| |||
101 | 98 | | |
102 | 99 | | |
103 | 100 | | |
104 | | - | |
105 | | - | |
106 | | - | |
| 101 | + | |
107 | 102 | | |
108 | 103 | | |
109 | 104 | | |
| |||
119 | 114 | | |
120 | 115 | | |
121 | 116 | | |
122 | | - | |
123 | | - | |
124 | | - | |
| 117 | + | |
125 | 118 | | |
126 | 119 | | |
127 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
0 commit comments