Skip to content

Commit fbcc709

Browse files
refactor: update QuoteRow to use primitive providerName prop
1 parent 3cc7495 commit fbcc709

3 files changed

Lines changed: 11 additions & 8 deletions

File tree

app/components/UI/Bridge/components/QuoteSelectorView/QuoteList.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import React from 'react';
22
import { render } from '@testing-library/react-native';
33
import { QuoteList } from './QuoteList';
4-
import { QuoteRowProps } from './QuoteRow';
4+
import { QuoteRowProps, QuoteRowViewProps } from './QuoteRow';
55
import { useSelector } from 'react-redux';
66
import { getDisplayCurrencyValue } from '../../utils/exchange-rates';
77

88
jest.mock('./QuoteRow', () => ({
9-
QuoteRowView: ({ provider, quoteRequestId }: QuoteRowProps) => {
9+
QuoteRowView: ({ providerName, quoteRequestId }: QuoteRowViewProps) => {
1010
const { Text } = jest.requireActual('react-native');
1111
return (
1212
<Text testID={`quote-row-${quoteRequestId}`}>
13-
{provider.name} - {quoteRequestId}
13+
{providerName} - {quoteRequestId}
1414
</Text>
1515
);
1616
},

app/components/UI/Bridge/components/QuoteSelectorView/QuoteList.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@ export const QuoteList = ({ data }: Props) => {
3131
nonEvmMultichainAssetRates = useSelector(selectMultichainAssetsRates);
3232
///: END:ONLY_INCLUDE_IF(keyring-snaps)
3333

34-
return data.map((quote) => (
34+
return data.map(({ provider, ...quote }) => (
3535
<QuoteRowView
3636
key={quote.quoteRequestId}
3737
{...quote}
38+
providerName={provider.name}
3839
formattedReceiveAmountFiat={getDisplayCurrencyValue({
3940
token: destToken,
4041
amount: quote.receiveAmount,

app/components/UI/Bridge/components/QuoteSelectorView/QuoteRow.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,16 @@ export interface QuoteRowProps {
3838
receiveAmount?: string;
3939
}
4040

41-
export interface QuoteRowViewProps extends QuoteRowProps {
41+
export interface QuoteRowViewProps extends Omit<QuoteRowProps, 'provider'> {
42+
providerName: string;
4243
formattedReceiveAmountFiat: string;
4344
destTokenSymbol?: string;
4445
}
4546

4647
export const QuoteRowView = React.memo(
4748
({
4849
selected,
49-
provider,
50+
providerName,
5051
isLowestCost,
5152
formattedTotalCost,
5253
formattedReceiveAmountFiat,
@@ -94,7 +95,7 @@ export const QuoteRowView = React.memo(
9495
fontWeight={FontWeight.Medium}
9596
variant={TextVariantDS.BodyMd}
9697
>
97-
{provider.name}
98+
{providerName}
9899
</Text>
99100
</View>
100101
</Skeleton>
@@ -151,7 +152,7 @@ export const QuoteRowView = React.memo(
151152
},
152153
);
153154

154-
export const QuoteRow = (props: QuoteRowProps) => {
155+
export const QuoteRow = ({ provider, ...props }: QuoteRowProps) => {
155156
const destToken = useSelector(selectDestToken);
156157
const formattedReceiveAmountFiat = useDisplayCurrencyValue(
157158
props.receiveAmount,
@@ -161,6 +162,7 @@ export const QuoteRow = (props: QuoteRowProps) => {
161162
return (
162163
<QuoteRowView
163164
{...props}
165+
providerName={provider.name}
164166
formattedReceiveAmountFiat={formattedReceiveAmountFiat}
165167
destTokenSymbol={destToken?.symbol}
166168
/>

0 commit comments

Comments
 (0)