fix: remove BottomSheetOverlay from QuickBuyRoot

Reverts the dismiss-on-outside-press regression introduced in 585d816.

The QuickBuy sheet is intentionally overlay-free: no scrim, no background
dimming, and the surface below stays interactive. BottomSheetOverlay was
blocking all touches on the underlying content and closing the sheet when
tapping outside, which is the opposite of the intended behaviour.

Also removes the now-unnecessary BottomSheetOverlay stub from
QuickBuySheet.test.tsx.

Author: salimtb

app/components/Views/SocialLeaderboard/TraderPositionView/components/QuickBuy/QuickBuyRoot.tsx

@@ -1,6 +1,5 @@
 import {
   BottomSheetDialog,
-  BottomSheetOverlay,
   type BottomSheetDialogRef,
   Box,
 } from '@metamask/design-system-react-native';
@@ -148,57 +147,46 @@ const QuickBuyRootInner: React.FC<QuickBuyRootInnerProps> = ({
   );
 
   return (
-    <>
-      <BottomSheetOverlay
-        onPress={
-          !isSubmittingTx
-            ? () => bottomSheetRef.current?.onCloseDialog()
-            : undefined
-        }
-      />
-      <BottomSheetDialog
-        ref={bottomSheetRef}
-        isInteractable={!isSubmittingTx}
-        onClose={onClose}
-        twClassName={surfaceClass}
-      >
-        {isContentReady ? (
-          <QuickBuyProvider
-            target={target}
-            onClose={requestClose}
-            features={features}
-            analyticsContext={analyticsContext}
-            activeScreen={activeScreen}
-            setActiveScreen={navigateToScreen}
+    <BottomSheetDialog
+      ref={bottomSheetRef}
+      isInteractable={!isSubmittingTx}
+      onClose={onClose}
+      twClassName={surfaceClass}
+    >
+      {isContentReady ? (
+        <QuickBuyProvider
+          target={target}
+          onClose={requestClose}
+          features={features}
+          analyticsContext={analyticsContext}
+          activeScreen={activeScreen}
+          setActiveScreen={navigateToScreen}
+        >
+          <Box
+            testID="quick-buy-content-container"
+            onLayout={handleContentLayout}
+            style={lockedHeight !== null ? { height: lockedHeight } : undefined}
           >
-            <Box
-              testID="quick-buy-content-container"
-              onLayout={handleContentLayout}
-              style={
-                lockedHeight !== null ? { height: lockedHeight } : undefined
-              }
+            <Animated.View
+              key={activeScreen}
+              entering={hasNavigated ? entering : undefined}
+              exiting={isClosing ? undefined : exiting}
+              style={lockedHeight !== null ? tw.style('flex-1') : undefined}
             >
-              <Animated.View
-                key={activeScreen}
-                entering={hasNavigated ? entering : undefined}
-                exiting={isClosing ? undefined : exiting}
-                style={lockedHeight !== null ? tw.style('flex-1') : undefined}
-              >
-                {renderActiveScreen(activeScreen, children)}
-              </Animated.View>
-            </Box>
-          </QuickBuyProvider>
-        ) : (
-          <AnimatedScrollView
-            style={tw.style('shrink')}
-            keyboardShouldPersistTaps="handled"
-            showsVerticalScrollIndicator={false}
-          >
-            <QuickBuyBottomSheetSkeleton />
-          </AnimatedScrollView>
-        )}
-      </BottomSheetDialog>
-    </>
+              {renderActiveScreen(activeScreen, children)}
+            </Animated.View>
+          </Box>
+        </QuickBuyProvider>
+      ) : (
+        <AnimatedScrollView
+          style={tw.style('shrink')}
+          keyboardShouldPersistTaps="handled"
+          showsVerticalScrollIndicator={false}
+        >
+          <QuickBuyBottomSheetSkeleton />
+        </AnimatedScrollView>
+      )}
+    </BottomSheetDialog>
   );
 };
 

app/components/Views/SocialLeaderboard/TraderPositionView/components/QuickBuy/QuickBuySheet.test.tsx

@@ -41,10 +41,6 @@ jest.mock('@metamask/design-system-react-native', () => {
 
   return {
     ...actual,
-    // Stub the overlay — its Animated fade uses useNativeDriver which isn't
-    // available in the test environment.
-    BottomSheetOverlay: () =>
-      ReactMock.createElement(View, { testID: 'mock-bottom-sheet-overlay' }),
     BottomSheetDialog: ReactMock.forwardRef(
       (
         {