Skip to content

[Bug]: Bad UX when removing selected active hardware wallet account while it is connected to a dapp #13865

Open
@cortisiko

Description

@cortisiko

Describe the bug

When a QR account is connected to a dapp and then removed, returning to the dapp gives the impression that the QR account is still connected. Even when attempting to submit a dapp transaction, it appears as though the QR account is in use. What happens is the selected account (based on what currently selected on the main wallet view) is the account being used to submit the transaction. Since the dapp's UI does not update to reflect the active account, this can be misleading and potentially risky, especially if I or a user ends up using funds from an unintended account.

NOTE: this bug is also reproducible using a ledger device.

Expected behavior

The removed QR account should behave just like a removed private key where it updates in the UI according.

Screenshots/Recordings

No response

Steps to reproduce

Scenario 1

Import a wallet
Connect a QR account
Go to a dapp
Connect at least 2 accounts to the dapp (including the qr account)
Switch to the QR account
And submit a txn or dapp interaction
Go to the wallet view and remove the qr account
Return to the dapp
Notice the dapp UI still shows the QR account is still connected. Furthermore, when you submit a transaction, notice the QR account still seems to be connected.

Lastly, If i were to kill and relaunch the app then return to the dapp, the QR account still appears to be connected.

Scenario 2

Import Ledger account
Go to a dapp and connect multiple accounts including the Ledger account
While on the dapp, swtich to the Ledger account
open the accounts bottom sheet again
Proceed to remove the Ledger account
Notice the dapp UI still shows the Ledger account is still connected.

Error messages or log output

Detection stage

During release testing

Version

7.42.0

Build type

None

Device

Samsung S8, iPhone 16 Pro

Operating system

Android

Additional context

No response

Severity

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    To be fixed

    Status

    To be triaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions