[Bug]: Switching networks / submitting transaction from PancakeSwap

[sleepytanya]

Describe the bug

1. Inconsistency in the transaction history when viewed from different networks (not sure if that is within the scope as we have an open bug for that)
2. If the first submitted transaction is STX, all subsequent txs are submitted as STX on networks that do not support STX. If the first tx is not STX then I can send regular txs on different networks
3. I noticed it for BNB only but the first swap has NaN instead of fiat value in simulation for the BNB token (the NaN is also on Erik's video)
4. When Settings -> Advanced -> STX are disabled, I can't send regular transaction on any network, the confirmation is stuck after tapping Confirm button

Expected behavior

Screenshots/Recordings

iOS (fresh install, regular tx is submitted is STX after first STX tx):
https://www.loom.com/share/14f45d0f6eb6463283202ae00bfc0951?sid=833f1253-5d78-4b65-a09a-85eeefea09a3

Android (the same behavior as iOS - just to confirm that we also get stuck tx after sending STX, while already having several successful txs):
https://www.loom.com/share/06942b8f3e12481bb887db5905cabad9?sid=d51622e2-5874-4e77-bf29-3ee5746b0acc

Android, STX Off, regular tx stuck on Confirmation screen:
https://www.loom.com/share/35958d98d2404f62bddb4ddaa1be7833?sid=d1346f76-181c-4616-ba10-d0bb5508e6f4

Steps to reproduce

1. Connect to PancakeSwap
2. Start / submit a swap

Error messages or log output

Detection stage

On a feature branch

Version

7.43.0 (1656)

Build type

None

Device

iPhone 15, Samsung S24 Ultra

Operating system

iOS, Android

Additional context

No response

Severity

No response

[EtherWizard33]

About the first two videos in the description, great find on finding the first stx transaction going through might be corruping all folowing transactions, I have let @dan437 know and we are looking into it together.

Also want to see if two stx in a row on bnb are successful and if these stx show in the expected block explorer as successful.

@sleepytanya For the last and 3rd video, could it be that the wallet had a successfull bnb stx before, because the result seems very similar to the one following a successful bnb stx while stx enabled?

[EtherWizard33]

@sleepytanya I have just completed my first meeting with @dan437 .

@dan437 suggested his team needs to fix the NaN issue, as well as stx non-supported chains going as tx, so there will be at least two new tickets created from this one, to make them specific issues. Will add links in next comment later below.

we have been able to reproduce the first stx blocking subsequent ones when subsequent ones are not stx compatible chains, yet it still attempts a stx type of transaction.

For the one displaying 'signed' and 'pending' in history, this one we are currently seeing the smart transaction showing canceled after the progress indicator screen, and showing as failed in the history. Which is different than the signed and pending states we can clearly see in your video, it might be tricky to reproduce. Maybe we had some small changes coming from the main branch that you did not have in the build i provided you, I will test the same on the build. In the mean time i will put two screenshots of this canceled and failed screens we see.

But for the last one, settings, when stx setting is disabled, the non-stx transaction went as expected, we were not able to reproduce this one.

Canceled screen after progress screen	Failed showing in history

[EtherWizard33]

First smaller bug, for the NaN assigned to team transactions #14654
Second one for non supported stx network is here #14655

cc @sleepytanya

[Unik0rnMaggie]

Hi Team,

Adding two videos for swapping on Pancakeswap with STX ON and OFF:

STX ON:

• first swap is successful
• min 1:40 showing a confirmation for Received Ether, but it's actually for BNB:

• min 3:20 second swap - approval button for CAKE token is greyed out.

• second swap is successful for a token that does not need approval

• min 6:12: View on Bscscan button missing from the transaction details (when Popular networks view is selected in the transaction list)

STX OFF

• swap is successful with STX OFF
• min 2:10: View on explorer button missing from transaction details for Linea network

[dan437]

Hi @MetaMask/confirmations team, could someone have a look at the stuck Approve button?