Skip to content

Performance Audit: Portfolio View #14690

Open
@sethkfman

Description

@sethkfman

What is this about?

This ticket defines the requirements and intended outcomes for an audit of the native mobile Portfolio View. This audit should help identify improvements or PoC. Each of these improvements should have an effort and impact associated.

The following areas of the Portfolio View should be exercised while using preferred performance tooling and a wallet with a predefined set of assets &NFTs to identify problems:

  • PV switch to popular networks
  • PV switch to current network
  • PV add custom network and switch
  • PV switch to Tokens & NFTS views

Areas of code to look at:

  • Views & Components
  • Navigation
  • Engine
  • Controllers

Scenario

No response

Design

These are the areas that we consider "portfolio view":

Image

Technical Details

UI components

Polling logic

Polling is defined here: app/components/hooks/AssetPolling/AssetPollingProvider.tsx where it triggers polling by calling the related controllers.
Polling is initially triggered by the tokenList component.

UI polling will trigger controller polling on the:
CurrencyRateController
TokenRatesController
TokenDetectionController
AccountTrackerController
TokenListController
TokenBalancesController

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions