-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
feature-branch-bugbug that was found on a feature branch, but not yet merged in main branchbug that was found on a feature branch, but not yet merged in main branchrelease-7.48.0Issue or pull request that will be included in release 7.48.0Issue or pull request that will be included in release 7.48.0team-confirmationsPush issues to confirmations teamPush issues to confirmations teamtype-enhancementNew feature or requestNew feature or request
Description
Describe the bug
Notes below are from testing the Wallet UX feature branch for this feature:
- Approval screen reflects globally selected network instead of the network selected in the current dApp. But the approval and subsequent swap submitted on the correct network
- Wallet broke with the error after switching network (zkSync) and starting a swap from Pancake Swap (maybe this error is present on
mainas well, I haven't checkedmain, but I never encountered this error in RC 7.45.0)
Expected behavior
Screenshots/Recordings
Incorrect Approval, error:
https://www.loom.com/share/d2fbb58ad14f4407a580bb548198dee9?sid=e292bd31-78a6-4025-b705-fc4c71d0d1f8
Incorrect Approval, just to confirm consistency:
https://www.loom.com/share/6fd8e7a98edc4d04ab6f30a0180f3420?sid=455a6274-5a47-41ca-939a-51ed1a2d8379
Approval from Sushi Swap - incorrect network on Approval screen, token and other data is not loaded, Confirm button is disabled:
https://www.loom.com/share/8382220279a04cac9a2a052b737d50aa?sid=cc7f4c6c-9bdc-4d51-90bc-ebdda915d336
Steps to reproduce
- Connect to Pancake Swap
- Start transaction
Error messages or log output
Detection stage
On a feature branch
Version
7.43.0
Build type
None
Device
Samsung S24 Ultra
Operating system
Android
Additional context
No response
Severity
No response
Metadata
Metadata
Assignees
Labels
feature-branch-bugbug that was found on a feature branch, but not yet merged in main branchbug that was found on a feature branch, but not yet merged in main branchrelease-7.48.0Issue or pull request that will be included in release 7.48.0Issue or pull request that will be included in release 7.48.0team-confirmationsPush issues to confirmations teamPush issues to confirmations teamtype-enhancementNew feature or requestNew feature or request