Possible bug in getScopesForAccountType when non-Eth accounts become available in prod

[MarioAslau]

What is this about?

Possible future bug in Migration 66, 67 inside getScopesForAccountType(), where we modify scopes.

When an account type isn't recognized in 66, the default case defaults to EthScoe.Eoa and migration continues.

If a user has a non Eth account and migration assigns incorrect Eth scopes, it could lead to a potential vault corruption if the account data structure doesn't match the assigned scopes.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• Engineering (needed in most cases)
• Design
• Product
• QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• Security
• Legal
• Marketing
• Management (please specify)
• Other (please specify)

References

No response

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• Engineering (needed in most cases)
• Design
• Product
• QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• Security
• Legal
• Marketing
• Management (please specify)
• Other (please specify)

References

No response