Open
Description
What is this about?
This is a follow up to correct a behavior for invalidating the e2e gate on PRs when new commits are pushed up. To further reduce the chance of untested changes breaking e2e on main, we'll want to ensure that either of the follow conditions are satisfied for a PR regarding e2e:
- There is a Bitrise comment with a success status that is associated with the latest commit
- There is a Bitrise comment with a success status that is associated with a commit within the last 10 commits. This scenario applies to the condition where the merge from main button is used in Github UI. For example, let's say I have a successful e2e test run against commit A and the PR lags behind on main. I can pull from latest using Github's UI assuming there are no conflicts. At that point, the PR would be on commit X. The gate would bypass/skip commit X and see that commit A is still valid. Another way to think about this is that the e2e gate can filter out commits created by pulling from main via Github UI
Scenario
No response
Design
No response
Technical Details
Refer to description
Threat Modeling Framework
No response
Acceptance Criteria
Refer to description
Stakeholder review needed before the work gets merged
- Engineering (needed in most cases)
- Design
- Product
- QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- Security
- Legal
- Marketing
- Management (please specify)
- Other (please specify)
References
No response