feat: bump @metamask/eip-5792-middleware to ^3.0.4#26664
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
@metamask/eip-5792-middleware to ^3.0.0@metamask/eip-5792-middleware to ^3.0.0
@metamask/eip-5792-middleware to ^3.0.0@metamask/eip-5792-middleware to ^3.0.0
| TransactionTypes.MMM_CARD, | ||
| ORIGIN_METAMASK, | ||
| ]; | ||
| ].filter(Boolean); |
There was a problem hiding this comment.
Cursor bot complaining that process.env.MM_FOX_CODE could be undefined which would result in INTERNAL_ORIGINS.includes(value) to return true if value === undefined. I think it complained about it in the other PR as well. I guess i listened to it here. Doesn't really matter. Can undo it as well
…to jl/eip-5792-middleware-3-0-0
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e30641. Configure here.
|
…to jl/eip-5792-middleware-3-0-0
@metamask/eip-5792-middleware to ^3.0.0@metamask/eip-5792-middleware to ^3.0.4
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: The changes in this PR affect several critical areas:
Tags selected:
Performance Test Selection: |
|




Description
Bump @metamask/eip-5792-middleware to ^3.0.4
Changelog
CHANGELOG entry: null
Please ping with any questions
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Updates EIP-5792 request handling to use origin-scoped permitted accounts, which can affect which accounts dapps see/use for
wallet_sendCalls/capabilities. Dependency bump pulls in newer transaction/controller utils versions, so behavior changes are possible even though the surface-area diff is small.Overview
Bumps
@metamask/eip-5792-middlewarefrom^2.0.0to^3.0.4(with updated lockfile).Updates the EIP-5792 RPC wiring so
wallet_getCapabilitiesandwallet_sendCallsderive accounts viagetPermittedAccounts(origin)rather than listing all accounts, aligning these methods with the permissions system; the unit test is adjusted accordingly.Cleans up
INTERNAL_ORIGINSby filtering out falsy entries to avoid leakingundefinedorigins into internal-origin checks.Reviewed by Cursor Bugbot for commit c1b28e2. Bugbot is set up for automated code reviews on this repo. Configure here.