test: migrates the page objects used by Flows.js#27494
test: migrates the page objects used by Flows.js#27494christopherferreira9 wants to merge 6 commits into
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| expect(PlaywrightMatchers.getElementByText).not.toHaveBeenCalled(); | ||
| expect(PlaywrightMatchers.getElementByAccessibilityId).not.toHaveBeenCalled(); | ||
| expect(PlaywrightMatchers.getElementByXPath).not.toHaveBeenCalled(); | ||
| expect(PlaywrightMatchers.getElementByCatchAll).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| await Gestures.tap(this.continueButton, { | ||
| elemDescription: 'Import Wallet Continue Button', | ||
| await UnifiedGestures.tap(this.continueButton, { | ||
| description: 'Import Wallet Continue Button', |
There was a problem hiding this comment.
tapContinueButton passes non-encapsulated element to UnifiedGestures
Medium Severity
tapContinueButton was migrated from Gestures.tap to UnifiedGestures.tap, but still passes this.continueButton which returns a plain DetoxElement instead of EncapsulatedElementType. In Appium context, AppiumGestureStrategy.tap would call .click() on a DetoxElement, which lacks that method. A properly encapsulated continueButtonEncapsulated getter already exists but isn't used here.
Additional Locations (1)
There was a problem hiding this comment.
Will fix in a follow up pr
|
✅ E2E Fixture Validation — Schema is up to date |
|
|
Closing as not relevant for now. |





Description
This PR migrates the page objects used by
Flows.js(performance related) to the new unified approach.Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1469
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it refactors multiple frequently-used E2E page objects and selector strategies (including new XPath/catch-all locators), which can introduce cross-platform test flakiness even though production code is unaffected.
Overview
Migrates the page objects used by performance
Flows.jsto the unifiedEncapsulatedElement/UnifiedGesturesapproach, adding Appium/Playwright selector paths alongside existing Detox locators.Adds new Appium-capable page objects/modals and expands existing onboarding and wallet page objects with cross-platform
isVisible/wait helpers and flow-specific actions (e.g., SRP word-by-word entry, account list syncing waits).Updates the migration test utilities and mocks to account for additional Playwright matcher types (
getElementByXPath,getElementByCatchAll) and introduces a simplePlaywrightGestures.tapwrapper used by the migrated objects.Written by Cursor Bugbot for commit 211f10f. This will update automatically on new commits. Configure here.