Skip to content

Add KONET mainnet network icon#28642

Open
zekto-dev-hong wants to merge 4 commits into
MetaMask:mainfrom
zekto-dev-hong:feat/add-konet-network-icons
Open

Add KONET mainnet network icon#28642
zekto-dev-hong wants to merge 4 commits into
MetaMask:mainfrom
zekto-dev-hong:feat/add-konet-network-icons

Conversation

@zekto-dev-hong
Copy link
Copy Markdown

@zekto-dev-hong zekto-dev-hong commented Apr 10, 2026

Description

This PR adds the KONET mainnet network icon to MetaMask Mobile.

Previously, when KONET mainnet was added as a custom network, it appeared with a placeholder icon in the network list. This change adds the KONET icon asset and maps chain ID 0x4341 in CustomNetworkImgMapping so the proper icon is displayed in the relevant custom network UI.

Changelog

CHANGELOG entry: Added the KONET mainnet icon for custom network display in MetaMask Mobile

Related issues

Fixes: #28638

Manual testing steps

Feature: KONET mainnet custom network icon

  Scenario: user views KONET mainnet in the network list
    Given MetaMask Mobile is running with this branch
    And KONET mainnet has been added as a custom network with chain ID 17217
    When user opens the network list in Settings > Networks
    Then KONET mainnet should display the proper KONET icon instead of the placeholder icon

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small, UI-only change limited to adding a new chain ID constant and image mapping; primary risk is a missing/incorrect asset path causing the icon to not render.

Overview
Adds explicit support for KONET Mainnet in custom network display by introducing NETWORK_CHAIN_ID.KONET_MAINNET (0x4341) and wiring it into CustomNetworkImgMapping to use the new konet.png asset instead of the placeholder icon.

Reviewed by Cursor Bugbot for commit d1dceda. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hlibbc
Copy link
Copy Markdown

hlibbc commented Apr 10, 2026

I have read the CLA Document and I hereby sign the CLA

@zekto-dev-hong zekto-dev-hong marked this pull request as ready for review April 14, 2026 00:17
@zekto-dev-hong
Copy link
Copy Markdown
Author

Hi team, all authors have signed the CLA, but the blocking CLA check still appears to be stale.
I do not seem to have permission to rerun the failed check from my side.
Could someone please rerun the CLA check for this PR?
Thank you.

@zekto-dev-hong
Copy link
Copy Markdown
Author

Hi team, following up on this KONET mobile icon PR.

This PR is ready for review, and the CLA/checks appear to be in order on my side.
Could someone please help triage this PR or point me to the appropriate reviewer/team for this change?

If any follow-up update is needed, I can address it quickly.
Thank you.

@zekto-dev-hong
Copy link
Copy Markdown
Author

Hi team,

Following up on this KONET Mainnet icon PR for MetaMask Mobile.

The PR is ready for review, CLA appears to be completed, and the scope is limited to the KONET custom network/native token icon mapping.

Could someone please help triage this or point me to the appropriate reviewer/team?

Happy to make any required changes quickly.

Thank you.

@zekto-dev-hong
Copy link
Copy Markdown
Author

Hi @jeremytsng @maxime-oe — pinging specific reviewers for the first
time, since this PR has been ready for review without an assigned
reviewer for ~30+ days.

The change pattern is identical to your recently merged additions:

Scope is the same: append KONET_MAINNET (chainId 17217, 0x4341) to
NETWORK_CHAIN_ID and add an entry to CustomNetworkImgMapping pointing
at app/images/konet.png. UI-only, no transaction/RPC/security paths
touched. Cursor Bugbot flagged it Low Risk.

Could either of you triage this when you have a moment? Happy to
address any follow-up quickly. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add KONET mainnet network icon to MetaMask Mobile

2 participants