fix: resolve ORDER_PRICE_REQUIRED error on perps position flip

[gambinish]

Description

TradingService.flipPosition() deliberately omits currentPrice from the order params it passes to provider.placeOrder() — passing a stale entry price would corrupt IOC slippage calculation. However, placeOrder() was running #validateOrderBeforePlacement before fetching the live price, so the minimum-USD check had no price to work with and threw ORDER_PRICE_REQUIRED on every flip.

Root cause: step ordering in HyperLiquidProvider.placeOrder(). Validation ran at step 1; the live price fetch (#getAssetInfo) ran at step 3.

Fix: reorder placeOrder() so #getAssetInfo runs first, compute effectivePrice (live price, or caller-supplied price if present), then pass it into #validateOrderBeforePlacement. #ensureReadyForTrading stays after validation, so invalid orders never trigger builder-fee / DEX-abstraction signature prompts unnecessarily.

As a follow-on, effectivePrice is hoisted above the try block so the $10-minimum retry path can also use the fetched price when the caller omits currentPrice — without this, a flip order that hit the $10 edge case would fail silently instead of retrying.

No changes to TradingService.flipPosition — the intentional omission of entryPrice is correct and preserved.

Affected tests:

Three HyperLiquidProvider tests updated to reflect the new ordering (the "missing price data" error now surfaces from #getAssetInfo rather than validation; the price-less PUMP retry test now succeeds with two exchange calls)
Two new tests added for the explicit flip-order path

Changelog

CHANGELOG entry: fix regression to flip position perps

Related issues

Fixes: MetaMask/metamask-extension#42375

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Screen.Recording.2026-05-04.at.3.01.17.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Changes the execution order in HyperLiquidProvider.placeOrder, affecting validation/signing flow and retry behavior for minimum-order errors. Risk is moderate because it touches core order placement logic, but the change is localized and covered by updated/new tests.

Overview
Fixes a regression where price-less market orders (notably flipPosition) failed with ORDER_PRICE_REQUIRED by fetching the live price via #getAssetInfo before provider-level validation and validating against the computed effectivePrice.

Also hoists effectivePrice so the "$10 minimum order value" retry path can derive an adjusted usdAmount from the fetched price when currentPrice is omitted. Updates existing tests and adds new coverage to assert success for flip-style params, the $10-minimum retry behavior, and the revised error surfaced when price data is missing.

^{Reviewed by Cursor Bugbot for commit 106369c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[michalconsensys]

@gambinish the PR looks good. I've tested it locally and everything seems to work well, however the unit tests are failing

[abretonc7s]

.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 15e9295. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: @PerformancePreps
• Risk Level: medium
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are isolated to HyperLiquidProvider.ts and its test file. The modifications refactor the placeOrder method to:

1. Fetch asset info/live price BEFORE validation (instead of after), so price-less callers like flipPosition can validate against the live fetched price
2. Hoist effectivePrice variable so the $10 minimum retry path can use the fetched price even when params.currentPrice is absent
3. Move #ensureReadyForTrading() after validation to avoid triggering signature prompts for invalid orders

These are behavioral changes to the perps order placement flow that directly affect the flipPosition path. The fix changes when validation occurs and what price is used for validation/retry logic.

SmokePerps: Directly affected - the placeOrder method is the core of perps trading. The flipPosition flow (which omits currentPrice) now works correctly. E2E tests should validate the Add Funds flow and position management.

SmokeWalletPlatform: Required per SmokePerps tag description - Perps is a section inside the Trending tab, and changes to Perps views affect Trending.

SmokeConfirmations: Required per SmokePerps tag description - Add Funds deposits are on-chain transactions that go through confirmations.

No UI components, navigation, shared components, or other feature areas are affected. The changes are purely in the provider layer of the perps controller.

Performance Test Selection:
The changes modify the order placement flow in HyperLiquidProvider, specifically reordering operations (price fetch before validation) and fixing the flipPosition path. While these are logic fixes rather than rendering changes, the reordering of async operations (price fetch → validation → ensureReadyForTrading) could affect the timing/performance of the perps Add Funds flow and order execution. @PerformancePreps covers perps market loading, position management, add funds flow, and order execution - all directly relevant to these changes.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud