Skip to content

fix: update font label in token details#29710

Merged
sahar-fehri merged 3 commits into
mainfrom
fix/update-font-token-details
May 6, 2026
Merged

fix: update font label in token details#29710
sahar-fehri merged 3 commits into
mainfrom
fix/update-font-token-details

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented May 5, 2026

Description

Update font for token details label.

Changelog

CHANGELOG entry: Update font for token details label

Related issues

Fixes: null

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only typography change that does not affect navigation, data, or analytics behavior.

Overview
Updates the SecurityTrustEntryCard result label styling by switching from TextVariant.HeadingMd with a hard-coded 600 weight to TextVariant.BodyMd with FontWeight.Medium, aligning the label’s typography with the design system.

Reviewed by Cursor Bugbot for commit 827c6b1. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri enabled auto-merge May 6, 2026 08:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change in SecurityTrustEntryCard.tsx is a purely cosmetic/styling fix:

  1. Changed text variant from TextVariant.HeadingMd to TextVariant.BodyMd - reduces text size to body text
  2. Changed font weight from hardcoded string '600' to proper enum FontWeight.Medium - a code quality fix

This component is used only in AssetOverviewContent.tsx (token details view). The change has no functional impact on any user flows, transaction logic, account management, network operations, or authentication. It's a minor visual adjustment to the security trust entry card label styling. No E2E test tags are warranted for this type of pure styling/cosmetic change, and there is no performance impact.

Performance Test Selection:
This is a minor text styling change (variant and font weight) with no impact on rendering performance, data loading, or any performance-sensitive flows.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@sahar-fehri sahar-fehri added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit d55e006 May 6, 2026
96 of 123 checks passed
@sahar-fehri sahar-fehri deleted the fix/update-font-token-details branch May 6, 2026 09:28
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XS team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants