fix: Patch detox to handle errors when injecting into WebViews#29733
Merged
FrederikBolding merged 3 commits intoMay 6, 2026
Merged
Conversation
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
51bbc68
into
chore/drop-snaps-xmlserializer-patch
99 of 110 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes Android test/build wiring for Detox (dependency resolution, Gradle module inclusion, flavor dimensions), which could break CI/e2e builds even though it shouldn’t affect production runtime.
Overview
Ensures Detox’s Android WebView HTML extraction doesn’t fail hard by wrapping the injected
GET_HTML_SCRIPTin atry/catchand returning a minimal empty HTML document on error.Switches the project to consume a Yarn-patched
detox@20.51.0and builds Detox from source in Gradle (include ':detox'+androidTestImplementation(project(path: ":detox"))), removing the oldDetox-androidMaven repo usage. Android app config is updated to resolve Detox’s flavor viamissingDimensionStrategy 'detox', 'full'.Reviewed by Cursor Bugbot for commit 17e05cb. Bugbot is set up for automated code reviews on this repo. Configure here.