Skip to content

test: Add cherry-picks section to RC build comment, update Slack message#29772

Open
sleepytanya wants to merge 6 commits into
mainfrom
mcrm-63-add-changelog
Open

test: Add cherry-picks section to RC build comment, update Slack message#29772
sleepytanya wants to merge 6 commits into
mainfrom
mcrm-63-add-changelog

Conversation

@sleepytanya
Copy link
Copy Markdown
Contributor

@sleepytanya sleepytanya commented May 6, 2026

Description

Add cherry-picks section to RC build comment and link Slack to PR.

  • Extract commits using git merge-base + ancestry-path
  • Display collapsible table in PR comment with anchor link
  • Update Slack to link to PR comment instead of listing commits
  • Remove dead code (test/e2e/exp mappings, unused git functions)
  • Fix fetch-depth for merge-base to work in CI

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCRM-74?actionerId=62972968b407cc0069ffc438&sourceType=assign

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes RC release automation by adding git-history extraction to the PR comment and wiring PR numbers through workflows; failures or unexpected git history/checkout behavior could affect release notifications/comments.

Overview
Adds a new “What’s in this RC” cherry-picks section to the RC build PR comment, generated from git history (merge-base + ancestry-path) and rendered as a collapsible markdown table with commit/PR links.

Updates the Slack RC notification to stop listing commits inline and instead link to the PR comment’s #cherry-picks anchor; workflows now pass pr_number into the reusable Slack workflow, and the RC comment job switches to fetch-depth: 0 to ensure history is available.

Tightens Remote Feature Flag env mapping by removing explicit test/e2e/exp handling (these now fall back to dev) in both the prod build env notifier and the RC env validation section.

Reviewed by Cursor Bugbot for commit cfabf44. Bugbot is set up for automated code reviews on this repo. Configure here.

@sleepytanya sleepytanya requested a review from a team as a code owner May 6, 2026 03:10
@sleepytanya sleepytanya added team-qa QA team No QA Needed Apply this label when your PR does not need any QA effort. labels May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label May 6, 2026
Comment thread scripts/build-announce/cherry-picks-section.ts Fixed
Comment thread scripts/build-announce/cherry-picks-section.ts Fixed
Comment thread scripts/build-announce/cherry-picks-section.ts Outdated
Comment thread scripts/slack-rc-notification.mjs
Comment thread scripts/build-announce/cherry-picks-section.ts
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit be35f59. Configure here.

Comment thread scripts/build-announce/index.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 7 changed files are purely CI/CD infrastructure and build announcement scripts with no impact on the mobile app code or E2E test infrastructure:

  1. .github/workflows/build-rc-auto.yml: Increases git fetch-depth to 0 (full history) and passes pr_number to the Slack notification job. This is a CI pipeline change only.

  2. .github/workflows/prod-build-env-notify.yml: Removes 'test', 'e2e', and 'exp' environment cases from a switch statement - these now fall through to 'dev'. Pure CI configuration change.

  3. .github/workflows/slack-rc-notification.yml: Adds a new pr_number input parameter and passes it as an env variable to the notification script. CI workflow change only.

  4. scripts/build-announce/cherry-picks-section.ts: New file that extracts cherry-pick commits from git history and formats them as markdown for PR comments. Build announcement script only.

  5. scripts/build-announce/env-validation-section.ts: Removes 'test', 'e2e', 'exp', and 'dev' cases from getRemoteFFEnv() - they now fall to default 'dev'. Build script change only.

  6. scripts/build-announce/index.ts: Integrates the new cherry-picks section into the PR comment body. Build announcement script only.

  7. scripts/slack-rc-notification.mjs: Refactored to replace inline git history extraction with a link to the cherry-picks section in the PR comment. Notification script only.

None of these changes affect: app source code, E2E test infrastructure (tests/, wdio/, detox), test page objects, test fixtures, navigation, controllers, UI components, or any other code that would require E2E validation. No performance-sensitive code is touched either.

Performance Test Selection:
No performance-sensitive code was changed. All changes are CI/CD pipeline scripts and build announcement utilities that have no impact on app rendering, data loading, state management, or any other performance-critical paths.

View GitHub Actions results

@sleepytanya sleepytanya changed the title Add CP section, update Slack link test: Add cherry-picks section to RC build comment, update Slack message May 6, 2026
@sleepytanya sleepytanya added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label May 6, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants