Skip to content

chore: adds "whats happening" to the Explore view#29778

Merged
zone-live merged 18 commits into
mainfrom
TSA-add-whats-happening-to-explore-view
May 6, 2026
Merged

chore: adds "whats happening" to the Explore view#29778
zone-live merged 18 commits into
mainfrom
TSA-add-whats-happening-to-explore-view

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented May 6, 2026

Description

Renders the existing WhatsHappeningSection at the top of the Explore page's Now tab (V2 layout), gated behind the FF.

Simulator Screenshot - iPhone 17 Pro - 2026-05-06 at 12 09 27

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds a feature-flagged UI section to the top of Explore’s Now tab plus a small ref-based refresh hook; no auth, persistence, or critical transaction logic changes.

Overview
Renders WhatsHappeningSection at the top of TrendingView/tabs/NowTab, gated by selectWhatsHappeningEnabled, and forwards a SectionRefreshHandle ref so the section can be refreshed when the tab’s refresh.trigger changes.

Adds a focused unit test (NowTab.test.tsx) that verifies flag-on renders, flag-off does not mount, and that a ref is passed to support pull-to-refresh without pulling in the section’s heavy dependencies.

Reviewed by Cursor Bugbot for commit d3b9432. Bugbot is set up for automated code reviews on this repo. Configure here.

@zone-live zone-live added the team-social-ai Social & AI team label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 185dbce. Configure here.

@github-actions github-actions Bot added the size-M label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to NowTab.tsx in the TrendingView, which adds the WhatsHappeningSection component (already used in Homepage) to the Trending "Now" tab, gated behind a feature flag (selectWhatsHappeningEnabled). The companion file is a new unit test. Key observations:

  1. Scope: Only 2 files changed - the NowTab component and its new unit test. No changes to controllers, navigation, Engine, or shared infrastructure.

  2. Feature flag gated: The WhatsHappeningSection is only rendered when isWhatsHappeningEnabled is true, meaning the default behavior is unchanged for most users.

  3. TrendingView impact: The NowTab is part of the Trending discovery tab, which is explicitly covered by SmokeWalletPlatform ("Covers the Trending discovery tab: search functionality, browsing content feeds (Predictions, Tokens, Perps, Sites sections), and browser navigation integration").

  4. No cascade effects: The WhatsHappeningSection is already an existing component used in Homepage - this is a reuse, not a new implementation. No new data fetching hooks or state management changes.

  5. No other tags needed: No confirmations, no account management, no network changes, no browser/dApp interactions affected.

Performance Test Selection:
The changes add a feature-flag-gated section to the TrendingView NowTab. The WhatsHappeningSection is an existing component already used in Homepage, so no new rendering patterns are introduced. The change is behind a feature flag (disabled by default), and there are no new list rendering, data fetching, or state management changes that would impact performance metrics.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

@Bigshmow Bigshmow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zone-live zone-live added this pull request to the merge queue May 6, 2026
Comment on lines +83 to +86
useEffect(() => {
if (refresh.trigger === 0) return;
whatsHappeningRef.current?.refresh();
}, [refresh.trigger]);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have any effect whenever the feature is disabled?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it has no effect, because if the Whats Happening entry is never rendered (FF off) the whatsHappeningRef.current will be null.

Merged via the queue into main with commit aac019d May 6, 2026
94 checks passed
@zone-live zone-live deleted the TSA-add-whats-happening-to-explore-view branch May 6, 2026 14:17
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-M team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants