Skip to content

test: migrates the WalletConnect performance test#29785

Merged
christopherferreira9 merged 4 commits into
mainfrom
cferreira/migrate-wc-performance
May 6, 2026
Merged

test: migrates the WalletConnect performance test#29785
christopherferreira9 merged 4 commits into
mainfrom
cferreira/migrate-wc-performance

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented May 6, 2026

Description

This PR migrates the WC performance test to the new framework.
skip-e2e has been applied since all changes are related to Appium.

Framework changes:

  • Allows for lazy fetch on getElementByNameiOS

iOS Run: https://app-automate.browserstack.com/dashboard/v2/builds/8c27168975bc74376449c6f9fa82158c549c8f41/sessions/195066d41131f7143a0b1989f5e0b710d39999f4 (Quality-Gates failed)
Android Run: https://app-automate.browserstack.com/dashboard/v2/builds/91d934900ddd178f4d255db708e8a14ac3153aed/sessions/05e33619e97368cfd712ec14a41c19033b01ce45

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1725

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it rewires a cross-context (native/web) performance test and adds new iOS/Android selectors and retry logic, which can introduce flaky behavior if locators or timing differ across devices.

Overview
Migrates the Uniswap WalletConnect performance interaction test from the legacy JS/WebdriverIO setup to the new Playwright-based fixture (uniswap-interaction.spec.js replaced with uniswap-interaction.spec.ts), updating flows to use loginToAppPlaywright, native-browser.flow, and PlaywrightContextHelpers.

Adds a new UniswapDapp page object to encapsulate Uniswap connect + WalletConnect + MetaMask deep link interactions and “Uniswap displayed” checks with platform-specific selectors and retry/wait helpers.

Extends test/framework selectors by adding an optional lazy mode to PlaywrightMatchers.getElementByNameiOS, and updates DappConnectionModal selectors/behavior for iOS (edit accounts) plus a small tap/refactor in network selection.

Reviewed by Cursor Bugbot for commit cdc8842. Bugbot is set up for automated code reviews on this repo. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner May 6, 2026 10:44
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-e2e skip E2E test jobs labels May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label May 6, 2026
Comment thread tests/performance/login/uniswap-interaction.spec.ts Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a514014. Configure here.


get SolanaPopup(): EncapsulatedElementType {
return this.solanaPopup;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused SolanaPopup getter is dead code

Low Severity

The PascalCase SolanaPopup getter is an alias for solanaPopup that is never referenced anywhere in the codebase. It was carried over from the old wdio UniswapDapp.js (which used this.SolanaPopup), but the new code exclusively uses the camelCase solanaPopup (in isUniswapDisplayed). This is dead code that adds confusion, especially since PascalCase getters are unconventional in TypeScript.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a514014. Configure here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@christopherferreira9 christopherferreira9 added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 38817db May 6, 2026
68 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/migrate-wc-performance branch May 6, 2026 13:45
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-M skip-e2e skip E2E test jobs team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants