test: migrates the WalletConnect performance test#29785
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a514014. Configure here.
|
|
||
| get SolanaPopup(): EncapsulatedElementType { | ||
| return this.solanaPopup; | ||
| } |
There was a problem hiding this comment.
Unused SolanaPopup getter is dead code
Low Severity
The PascalCase SolanaPopup getter is an alias for solanaPopup that is never referenced anywhere in the codebase. It was carried over from the old wdio UniswapDapp.js (which used this.SolanaPopup), but the new code exclusively uses the camelCase solanaPopup (in isUniswapDisplayed). This is dead code that adds confusion, especially since PascalCase getters are unconventional in TypeScript.
Reviewed by Cursor Bugbot for commit a514014. Configure here.
|





Description
This PR migrates the WC performance test to the new framework.
skip-e2ehas been applied since all changes are related to Appium.Framework changes:
getElementByNameiOSiOS Run: https://app-automate.browserstack.com/dashboard/v2/builds/8c27168975bc74376449c6f9fa82158c549c8f41/sessions/195066d41131f7143a0b1989f5e0b710d39999f4 (Quality-Gates failed)
Android Run: https://app-automate.browserstack.com/dashboard/v2/builds/91d934900ddd178f4d255db708e8a14ac3153aed/sessions/05e33619e97368cfd712ec14a41c19033b01ce45
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1725
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk because it rewires a cross-context (native/web) performance test and adds new iOS/Android selectors and retry logic, which can introduce flaky behavior if locators or timing differ across devices.
Overview
Migrates the Uniswap WalletConnect performance interaction test from the legacy JS/WebdriverIO setup to the new Playwright-based fixture (
uniswap-interaction.spec.jsreplaced withuniswap-interaction.spec.ts), updating flows to useloginToAppPlaywright,native-browser.flow, andPlaywrightContextHelpers.Adds a new
UniswapDapppage object to encapsulate Uniswap connect + WalletConnect + MetaMask deep link interactions and “Uniswap displayed” checks with platform-specific selectors and retry/wait helpers.Extends test/framework selectors by adding an optional
lazymode toPlaywrightMatchers.getElementByNameiOS, and updatesDappConnectionModalselectors/behavior for iOS (edit accounts) plus a small tap/refactor in network selection.Reviewed by Cursor Bugbot for commit cdc8842. Bugbot is set up for automated code reviews on this repo. Configure here.