Skip to content

chore: remove allDetectedTokens references#30049

Open
bergarces wants to merge 9 commits into
mainfrom
all-detected-tokens-references
Open

chore: remove allDetectedTokens references#30049
bergarces wants to merge 9 commits into
mainfrom
all-detected-tokens-references

Conversation

@bergarces
Copy link
Copy Markdown
Contributor

@bergarces bergarces commented May 12, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Removes the in-app Detected Tokens import/hide flow and stops auto-importing detected tokens in Wallet/useEarnNetworkPolling, which can change token discovery behavior and related navigation paths.

Overview
Eliminates legacy token-detection UI and state usage by removing the DetectedTokens/DetectedTokensConfirmation modal flow, its route/type entries, and associated unit/E2E tests.

Refactors hooks/selectors and test fixtures to no longer reference TokensController.allDetectedTokens (including dropping detected-token lookups in useAssetBalances and removing deprecated detected-token selectors), and trims Wallet/Earn polling logic that previously imported detected tokens into TokensController.

Reviewed by Cursor Bugbot for commit 58d7573. Bugbot is set up for automated code reviews on this repo. Configure here.

@bergarces bergarces requested review from a team as code owners May 12, 2026 15:11
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-XL labels May 12, 2026
Comment thread app/components/Views/Wallet/index.test.tsx
Comment thread app/components/Views/Wallet/index.tsx
@bergarces bergarces changed the title remove allDetectedTokens references chore: remove allDetectedTokens references May 12, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f0dd27e. Configure here.

Comment thread app/components/UI/Earn/hooks/useEarnNetworkPolling.test.ts
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-XL team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant