chore: remove allDetectedTokens references#30049
Open
bergarces wants to merge 9 commits into
Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f0dd27e. Configure here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Removes the in-app Detected Tokens import/hide flow and stops auto-importing detected tokens in
Wallet/useEarnNetworkPolling, which can change token discovery behavior and related navigation paths.Overview
Eliminates legacy token-detection UI and state usage by removing the
DetectedTokens/DetectedTokensConfirmationmodal flow, its route/type entries, and associated unit/E2E tests.Refactors hooks/selectors and test fixtures to no longer reference
TokensController.allDetectedTokens(including dropping detected-token lookups inuseAssetBalancesand removing deprecated detected-token selectors), and trimsWallet/Earn polling logic that previously imported detected tokens intoTokensController.Reviewed by Cursor Bugbot for commit 58d7573. Bugbot is set up for automated code reviews on this repo. Configure here.