Skip to content

fix: cp-7.78.0 add correct permissions to running perf builds#30223

Merged
cortisiko merged 1 commit into
mainfrom
ci/fix-experimental-perf-e2e-build
May 15, 2026
Merged

fix: cp-7.78.0 add correct permissions to running perf builds#30223
cortisiko merged 1 commit into
mainfrom
ci/fix-experimental-perf-e2e-build

Conversation

@cortisiko
Copy link
Copy Markdown
Member

@cortisiko cortisiko commented May 15, 2026

Description

Updates the run-performance-e2e-experimental.yml and run-performance-e2e-release.yml GitHub Actions workflows to grant permissions.contents: write (instead of read-only) so they are at least as permissive as the reusable run-performance-e2e.yml workflow they call.

Adds an inline comment documenting the transitive requirement (via the BrowserStack upload workflows).

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk workflow-only change that broadens GitHub token permissions to match the called reusable workflow; main risk is over-permissioning if not actually required.

Overview
Updates the run-performance-e2e-experimental.yml and run-performance-e2e-release.yml GitHub Actions workflows to grant permissions.contents: write (instead of read-only) so they are at least as permissive as the reusable run-performance-e2e.yml workflow they call.

Adds an inline comment documenting the transitive requirement (via the BrowserStack upload workflows).

Reviewed by Cursor Bugbot for commit 54b2260. Bugbot is set up for automated code reviews on this repo. Configure here.

@cortisiko cortisiko requested a review from a team as a code owner May 15, 2026 00:22
@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 15, 2026
@cortisiko cortisiko added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels May 15, 2026
@cortisiko cortisiko enabled auto-merge May 15, 2026 00:25
@cortisiko cortisiko changed the title test: add correct permissions to running perf builds test: cp-7.78.0 add correct permissions to running perf builds May 15, 2026
@cortisiko cortisiko changed the title test: cp-7.78.0 add correct permissions to running perf builds fix: cp-7.78.0 add correct permissions to running perf builds May 15, 2026
@sonarqubecloud
Copy link
Copy Markdown

@cortisiko cortisiko added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 8fbb9a4 May 15, 2026
121 of 129 checks passed
@cortisiko cortisiko deleted the ci/fix-experimental-perf-e2e-build branch May 15, 2026 00:41
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants