fix: Polish Settings list for consistency

[amandaye0h]

Description

This PR refines the typography for list items in Settings so the UI is consistent.

Changelog

CHANGELOG entry: null

Related issues

Fixes:
#30171
#30229

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Before	After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeWalletPlatform
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a pure UI/design-system migration in SettingsDrawer/index.js:

1. Migrates Text import from local component library to @metamask/design-system-react-native
2. Updates TextVariant and TextColor enum values to new design system naming conventions
3. Minor padding adjustments (splitting padding: 16 into individual sides)
4. No functional logic changes, no new features, no state management changes

Impact areas:

• app/components/Views/Settings/index.tsx — the main Settings screen uses SettingsDrawer for all settings rows (General, Security, SRP export, etc.)
• app/components/Views/OnboardingSuccess/DefaultSettings/index.tsx — the default settings screen shown during onboarding

Tag selection rationale:

• SmokeAccounts: Settings screen contains SRP reveal/export flows and account management settings. The SettingsDrawer renders these rows, so visual regression could affect these flows.
• SmokeWalletPlatform: Covers wallet lifecycle analytics and multi-SRP architecture settings. The Settings screen is central to these flows.

Tags NOT selected:

• No confirmations, swap, stake, browser, snaps, network, or identity flows are directly affected by this styling change.
• The change is low-risk (cosmetic only), so a targeted subset of tests is appropriate rather than a full suite.

Risk: Low — purely cosmetic/design-system migration with no functional changes. The main risk is a visual regression where text variants or colors render incorrectly, which the selected smoke tests would catch.

Performance Test Selection:
The changes are purely cosmetic UI updates (text variant names, color token names, minor padding adjustments). There are no changes to rendering logic, list performance, data loading, state management, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud