Skip to content

test: adds diagnosis for launchArgs monitoring#30240

Open
christopherferreira9 wants to merge 4 commits into
mainfrom
cferreira/investigate-launch-args
Open

test: adds diagnosis for launchArgs monitoring#30240
christopherferreira9 wants to merge 4 commits into
mainfrom
cferreira/investigate-launch-args

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented May 15, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Primarily affects E2E/test-only paths, but it adds new network proxy/diagnostic hooks in shim.js and posts extra data during app startup, which could impact test stability if misconfigured.

Overview
Adds an end-to-end diagnostics pipeline to make CI failures easier to debug. The app now records launch-argument/test config details on a shared globalThis testConfig, appends those details to fixture fetch URLs, and posts structured diagnostics (including remote feature flag update phases) back to the host mock server during E2E runs.

On the test runner side, MockServerE2E accepts /e2e-diagnostics, stores a bounded history, and includes recent diagnostics in “live request” failure errors; FixtureHelper.withFixtures captures rich failure artifacts (screenshots, view hierarchy, redacted metadata, mock-server/feature-flag request info) via a new tests/framework/E2EDiagnostics.ts, and the E2E GitHub Actions workflow now archives/uploads these diagnostics artifacts on failures.

Reviewed by Cursor Bugbot for commit 4c7a838. Bugbot is set up for automated code reviews on this repo. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner May 15, 2026 11:49
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run labels May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c6acce5. Configure here.

Comment thread app/util/test/utils.js Outdated
@christopherferreira9 christopherferreira9 changed the title test: adds diagnosis for launcArgs monitoring test: adds diagnosis for launchArgs monitoring May 15, 2026
…-launch-args

# Conflicts:
#	.github/workflows/run-e2e-workflow.yml
@christopherferreira9 christopherferreira9 requested a review from a team as a code owner May 15, 2026 15:51
@github-actions github-actions Bot added size-L and removed size-M labels May 15, 2026
@github-actions github-actions Bot added size-XL and removed size-L labels May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XL skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant