Skip to content

Money account uat testing#30244

Draft
Jwhiles wants to merge 10 commits into
mainfrom
money-account-uat-testing
Draft

Money account uat testing#30244
Jwhiles wants to merge 10 commits into
mainfrom
money-account-uat-testing

Conversation

@Jwhiles
Copy link
Copy Markdown
Contributor

@Jwhiles Jwhiles commented May 15, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeMoney, SmokeConfirmations, SmokeSwap, SmokeIdentity, SmokeWalletPlatform, SmokePerps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 78%
click to see 🤖 AI reasoning details

E2E Test Selection:

Analysis

Core Engine Controller Changes (devApiEnv infrastructure)

The PR introduces a centralized app/core/devApiEnv.ts module providing a build-time switch (MM_DEV_API_ENV) to route all backend services to dev vs. prod environments. Multiple critical controller init files are modified:

  • authentication-controller-init.ts: Now passes authEnv() to AuthenticationController config (previously no env override = hardcoded PRD default)
  • user-storage-controller-init.ts: Now passes authEnv() to UserStorageController config
  • authenticated-user-storage-service-init.ts: Now uses devApiEnv() instead of hardcoded 'prod'
  • create-notification-services-controller.ts: Now passes env to notification services
  • profile-metrics-service-init.ts: Now uses authEnv() instead of hardcoded SDK.Env.PRD
  • social-service-init.ts: Now uses apiUrl() for URL rewriting
  • chomp-api-service-init.ts: Dev override URL logic added
  • backend-websocket-service-init.ts: WebSocket URL now switches based on env

Key insight: These changes default to 'prod' behavior when MM_DEV_API_ENV is unset. In production/main builds, behavior is identical to before. However, the initialization path for AuthenticationController and UserStorageController has changed (explicit env config now passed), which could affect identity/sync flows.

Money/Card UI Changes (Significant Functional Changes)

  • New MoneyTransactionDetailsSheet: New bottom sheet component for transaction details navigation
  • MoneyHomeView: Activity item press now navigates to transaction details (replaces "under construction" alert)
  • useMoneyAccountTransactions: Now reads real transactions from TransactionController (not just mock data) - major behavioral change
  • useMoneyTransactionDisplayInfo: Major expansion - source token info, EIP-7702 batch transaction support, native token handling
  • moneyActivityFilters: Updated for EIP-7702 batch transactions
  • activityStyles: Updated for batch transactions
  • New route: TRANSACTION_DETAILS_SHEET added to Routes.MONEY.MODALS
  • MoneyActivityItem/List: onPress signature changed to pass transactionId

Bridge/Swap Changes

  • bridge.ts: BRIDGE_API_BASE_URL now also switches to dev when MM_DEV_API_ENV=dev (in addition to existing BRIDGE_USE_DEV_APIS)

Perps Changes

  • perpsConfig.ts: DATA_LAKE_API_CONFIG.OrdersEndpoint now uses apiUrl() for env-aware URL

Tag Justification

  • SmokeMoney: Direct functional changes to Money/Card UI - new transaction details sheet, real transaction data integration, EIP-7702 batch support. Core Money feature testing required.
  • SmokeConfirmations: MoneyTransactionDetailsSheet uses TransactionDetails and useTransactionDetails from confirmations components. EIP-7702 batch transaction handling touches confirmation flows. Per SmokeMoney description, also select SmokeConfirmations for Add Funds flows.
  • SmokeSwap: BRIDGE_API_BASE_URL change could affect swap/bridge flows. Per SmokeMoney description, when selecting SmokeMoney for Add Funds flows, also select SmokeSwap.
  • SmokeIdentity: AuthenticationController and UserStorageController initialization paths changed (explicit env config now passed). Identity/sync flows should be validated.
  • SmokeWalletPlatform: Per SmokeMoney tag description, when changes touch wallet home or actions entry to buy/sell, also select SmokeWalletPlatform. Money home view changes qualify.
  • SmokePerps: perpsConfig.ts changes affect Perps data lake API URL. Per SmokePerps description, also select SmokeWalletPlatform and SmokeConfirmations (already included).

Performance Test Selection:
The changes are primarily: (1) dev-only infrastructure (devApiEnv.ts) that defaults to prod behavior and doesn't affect UI rendering performance, (2) Money UI functional changes (new transaction details sheet, real transaction data) which are feature additions rather than performance-critical rendering changes. The Money activity list reads from TransactionController now, but this is a selector-based approach that shouldn't introduce performance regressions. No changes to account list rendering, app startup, login flows, or other performance-critical paths that would warrant performance test execution.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
39.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants