fix: release-blocker restore gas estimate alerts cp-7.78.0

[maxime-oe]

Description

Fixes release blocker regression #30260 for release 7.78.0

Changelog

CHANGELOG entry: restores gas estimate alerts on all networks except strictly gas-sponsored ones

Related issues

Fixes: #30260

Manual testing steps

Same testing intructions as for #29835
Add non-regression for issues raised in #30260

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Changes the conditions for showing the gas estimate failed warning based on a remote feature-flagged sponsored-network map and hardware-wallet detection, which could affect when users see (or miss) an important fee warning.

Overview
Restores the GasEstimateFailed warning logic to be suppressed only when the current chainId is flagged as gas-fee-sponsored, instead of relying on useIsGaslessSupported/pending checks.

The hook now reads transactionMeta to determine chainId and from address, and it explicitly keeps the alert enabled for hardware-wallet accounts even on sponsored networks. Tests were updated to mock the sponsored-network selector and isHardwareAccount, and to cover the sponsored-network and hardware-wallet exception cases.

^{Reviewed by Cursor Bugbot for commit bc78256. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 08c4b6f. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to the useGasEstimateFailedAlert hook and its test file within the confirmations hooks/alerts directory. The hook is refactored to replace useIsGaslessSupported with a direct check using getGasFeesSponsoredNetworkEnabled (feature flag selector) and isHardwareAccount utility. The key behavioral change is: hardware wallet users will now see the gas estimate failed alert even on gas-sponsored networks (since hardware wallets cannot use gas sponsorship). This directly affects the transaction confirmation UI alert system. The hook is imported by useConfirmationAlerts.ts, which aggregates all confirmation alerts. SmokeConfirmations is the appropriate tag as it covers transaction confirmation flows including gas fee handling. No other areas (accounts, identity, browser, snaps, swaps, etc.) are affected. No performance impact expected from this alert logic change.

Performance Test Selection:
The changes are limited to a React hook that computes alert state for gas estimation failures. This is a simple boolean computation with no rendering loops, list operations, or data fetching that would impact performance metrics.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud