ci(ci-namespace-shadow): never block merge gate; fix dispatch run URL#30282
Open
bsgrigorov wants to merge 2 commits into
Open
ci(ci-namespace-shadow): never block merge gate; fix dispatch run URL#30282bsgrigorov wants to merge 2 commits into
bsgrigorov wants to merge 2 commits into
Conversation
Parse shadow run URL from gh workflow run stdout instead of polling gh run list. Use continue-on-error on OIDC, token exchange, and dispatch; dispatch never exits non-zero so the namespace shadow workflow check does not block ALLGREEN. Related: INFRA-3631 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
alucardzom
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Namespace shadow (
ci-namespace-shadow.yml) is a PR-visible GitHub check that only dispatches full CI on Namespace in the background. It must never fail the merge queue / ALLGREEN when OIDC, token exchange, orgh workflow runmisbehaves.This PR:
Non-blocking check — Adds
continue-on-error: trueto the OIDC and token exchange steps (dispatch already had it) and documents that the job conclusion must stay success for merge policy. Failed steps still surface as annotations for operators.Correct, race-free run link — Replaces
gh run listpolling (could pick another branch’s dispatch or lag) with capturinggh workflow runstdout/stderr and parsing the run URL GitHub documents there, matching the same pattern we validated locally. On failure or missing URL, the step logs::error::/::warning::and leavesrun_urlempty instead of exiting non-zero.Local verification hints — Inline comments for testing the URL parse pipeline without repo-added helper scripts.
Changelog
CHANGELOG entry: null
Related issues
Fixes: INFRA-3631
Manual testing steps
Screenshots/Recordings
N/A — GitHub Actions workflow only.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Made with Cursor
Note
Low Risk
Low risk workflow-only change; it mainly relaxes failure handling and adjusts how the dispatched run URL is captured, with the main risk being reduced visibility if dispatch/token exchange fails silently.
Overview
Ensures the
CI (Namespace shadow)dispatcher workflow never blocks the PR merge gate by making the OIDC token fetch, token exchange, and dispatch steps best-effort (continue-on-error: true) and logging errors instead of failing the job.Fixes the shadow run link generation by capturing
gh workflow runoutput and parsing the created run URL directly, replacing the previousgh run listpolling that could race or select the wrong run; emits a warning and leavesrun_urlempty if the URL can’t be determined.Reviewed by Cursor Bugbot for commit 6cb3b4a. Bugbot is set up for automated code reviews on this repo. Configure here.