Skip to content

ci(ci-namespace-shadow): never block merge gate; fix dispatch run URL#30282

Open
bsgrigorov wants to merge 2 commits into
mainfrom
phase5d/workflow-dispatch-tracing
Open

ci(ci-namespace-shadow): never block merge gate; fix dispatch run URL#30282
bsgrigorov wants to merge 2 commits into
mainfrom
phase5d/workflow-dispatch-tracing

Conversation

@bsgrigorov
Copy link
Copy Markdown
Contributor

@bsgrigorov bsgrigorov commented May 15, 2026

Description

Namespace shadow (ci-namespace-shadow.yml) is a PR-visible GitHub check that only dispatches full CI on Namespace in the background. It must never fail the merge queue / ALLGREEN when OIDC, token exchange, or gh workflow run misbehaves.

This PR:

  1. Non-blocking check — Adds continue-on-error: true to the OIDC and token exchange steps (dispatch already had it) and documents that the job conclusion must stay success for merge policy. Failed steps still surface as annotations for operators.

  2. Correct, race-free run link — Replaces gh run list polling (could pick another branch’s dispatch or lag) with capturing gh workflow run stdout/stderr and parsing the run URL GitHub documents there, matching the same pattern we validated locally. On failure or missing URL, the step logs ::error:: / ::warning:: and leaves run_url empty instead of exiting non-zero.

  3. Local verification hints — Inline comments for testing the URL parse pipeline without repo-added helper scripts.

Changelog

CHANGELOG entry: null

Related issues

Fixes: INFRA-3631

Manual testing steps

Feature: Namespace shadow dispatcher workflow

  Scenario: Workflow definition is valid and merge-safe
    Given the change is limited to ci-namespace-shadow.yml
    When a reviewer inspects the dispatch step and continue-on-error usage
    Then OIDC, exchange, and dispatch must not fail the job conclusion
    And the step summary may show an empty shadow run link when dispatch is skipped

Screenshots/Recordings

N/A — GitHub Actions workflow only.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Low Risk
Low risk workflow-only change; it mainly relaxes failure handling and adjusts how the dispatched run URL is captured, with the main risk being reduced visibility if dispatch/token exchange fails silently.

Overview
Ensures the CI (Namespace shadow) dispatcher workflow never blocks the PR merge gate by making the OIDC token fetch, token exchange, and dispatch steps best-effort (continue-on-error: true) and logging errors instead of failing the job.

Fixes the shadow run link generation by capturing gh workflow run output and parsing the created run URL directly, replacing the previous gh run list polling that could race or select the wrong run; emits a warning and leaves run_url empty if the URL can’t be determined.

Reviewed by Cursor Bugbot for commit 6cb3b4a. Bugbot is set up for automated code reviews on this repo. Configure here.

Parse shadow run URL from gh workflow run stdout instead of polling gh run list.
Use continue-on-error on OIDC, token exchange, and dispatch; dispatch never exits
non-zero so the namespace shadow workflow check does not block ALLGREEN.

Related: INFRA-3631
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-dev-ops DevOps team label May 15, 2026
@bsgrigorov bsgrigorov marked this pull request as ready for review May 15, 2026 22:05
@bsgrigorov bsgrigorov requested a review from a team as a code owner May 15, 2026 22:05
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants