Ci/fix ios performance ipa uploads

[cortisiko]

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 4 changed files are CI/build infrastructure changes with no impact on app source code or E2E test logic:

1. .github/workflows/build-ios-upload-to-browserstack.yml: Robustness fix for IPA file discovery (case-insensitive -iname, error suppression, debug output when files not found). Pure CI workflow improvement.

2. builds.yml: Adds explicit IS_SIM_BUILD: 'false' and IS_BROWSERSTACK_BUILD: 'true' flags to BrowserStack build configurations (e2e, rc, exp variants). This ensures device builds are correctly targeted without relying on implicit logic.

3. scripts/build.sh: Simplifies IS_SIM_BUILD detection logic - removes the complex conditional that set IS_SIM_BUILD based on IS_BROWSERSTACK_BUILD at runtime, and changes the condition from checking if IS_SIM_BUILD is empty (-z) to checking if it's not "true". The logic is now driven by explicit values in builds.yml rather than runtime inference.

4. scripts/rename-artifacts.js: Adds fallback IPA discovery when the IPA isn't at the expected path (Xcode may name it differently). Pure robustness fix for artifact renaming.

None of these changes touch app source code, React Native components, controllers, navigation, or E2E test files. They are purely build/CI pipeline fixes for iOS BrowserStack artifact handling. No E2E test tags are warranted.

Performance Test Selection:
No app source code changes were made. All changes are CI/build infrastructure fixes for iOS BrowserStack artifact handling. There is no impact on app performance, rendering, state management, or any user-facing functionality.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud