Predictions: 'Something went wrong' error when adding funds via QR/HW wallet (OneKey)

[vivek-consensys]

Description

When attempting to add funds via a QR or hardware wallet in the Predictions feature, a 'Something went wrong' error is returned instead of a graceful unsupported device message. Reproduced using a OneKey hardware wallet on iOS RC build v8.3.0 (6070).

Steps to Reproduce

1. Add Hardware wallet (OneKey)
2. Import accounts from OneKey device
3. Navigate to Predictions
4. Tap "Add hardware wallet"
5. 'Something went wrong' error appears

Expected Result

Graceful error handling, as HW wallets are not supported in Predictions. A user-friendly message should indicate that hardware wallets are not supported rather than displaying a generic error.

Actual Result

A generic 'Something went wrong' error is displayed with no indication that hardware wallets are unsupported in this flow.

Detection stage

Release Candidate

Version

v8.3.0 (iOS 6070)

Build type

RC (Release Candidate)

Browser

N/A (iOS app)

Operating system

iOS

Hardware wallet

OneKey

Additional context

Issue may also affect QR wallet flows. Not confirmed on software accounts.

Media

HW-AddFunds-Predictions.MP4

---

Filed via Claude bug reporter

[metamask-ci]

Triage Agent -- Classification

Severity: Sev2 (confidence: 0.88) ✅

The Predictions feature shows a generic 'Something went wrong' error instead of a graceful 'unsupported device' message when users attempt to add funds via a QR/hardware wallet (OneKey). The feature is partially broken for hardware wallet users - they can't use it, but the error handling is the main issue (should show a clear unsupported message). Software wallet users are unaffected. A workaround exists (use a software wallet instead).

Size: size-S (confidence: 0.80) ⚠️ Advisory

The fix likely involves adding a check for hardware/QR wallet types in the Predict deposit flow and showing an appropriate unsupported device message instead of letting the operation fail with a generic error. This is a well-scoped change - add a guard/check before initiating the deposit flow, and surface a user-friendly error message.
Not auto-applied -- confidence below threshold.

Team: team-predict ✅

Matched via area fallback: area-predict (no CODEOWNERS match)

---

Root Cause Analysis

Affected component: Predict deposit/add-funds flow

The Predict deposit flow does not check whether the currently selected account is a hardware wallet (QR-based or otherwise) before attempting to initiate the funding operation. When a hardware wallet account is selected, the deposit flow likely tries to perform an operation (e.g., signing a transaction or interacting with a smart contract) that is incompatible with hardware wallet signing flows, causing an unhandled error that surfaces as a generic 'Something went wrong' message. The Predict feature likely needs to either: (1) detect hardware/QR wallet account types and show an 'unsupported wallet type' message before attempting the deposit, or (2) properly catch the hardware wallet-specific error and map it to a user-friendly message. The usePredictActionGuard hook (mentioned in KB as composing eligibility and account state) is the likely place where this wallet type check should occur but currently doesn't filter by keyring type.

Evidence:

• Generic 'Something went wrong' error instead of specific hardware wallet error
• Error only occurs with hardware wallet (OneKey) accounts
• The predict-user-lifecycle KB mentions usePredictActionGuard that gates user interactions based on account/eligibility state - this guard likely doesn't check for hardware wallet account types
• The hardware-wallet-error-handling framework exists but the Predict feature doesn't appear to integrate with it
• usePredictAccountState handles errors generically via Logger.error without hardware wallet-specific handling

Suggested Fix

Confidence: medium: likely but needs investigation - the exact deposit flow files and action guard implementation are not in the provided KB context, but the pattern is clear from the symptoms and available code

Add a hardware wallet / QR wallet type check in the Predict deposit flow (likely in usePredictActionGuard or the deposit initiation handler) that detects when the selected account is a hardware wallet and shows an appropriate 'unsupported wallet type' message instead of attempting the deposit operation.

Target files: app/components/UI/Predict/hooks/usePredictActionGuard.ts, app/components/UI/Predict/hooks/usePredictDeposit.ts
Target functions: usePredictActionGuard, deposit flow initiation handler

Approach:

1. Identify the hook or component that initiates the 'Add funds' / deposit flow in Predictions (likely usePredictActionGuard or a deposit hook). 2. Before allowing the deposit action, check the selected account's keyring type using the KeyringController or account metadata to determine if it's a hardware wallet (QR keyring type like 'QR Hardware Wallet Device' or similar). 3. If the account is a hardware wallet type, return an action guard result that blocks the action and provides a user-friendly message like 'Hardware wallets are not currently supported for Predictions. Please use a software wallet.' 4. Alternatively, wrap the deposit flow in a try-catch that catches hardware wallet-specific errors and maps them to a user-friendly unsupported message using the existing hardware wallet error framework. 5. Add the appropriate UI to display this message (e.g., a bottom sheet or alert). Note: The exact file paths for usePredictActionGuard and the deposit flow are not in the KB context, so search for these in the app/components/UI/Predict/ directory.

---

Confidence threshold: 0.85. Labels marked ✅ were auto-applied. Labels marked ⚠️ are advisory only (below threshold).
To re-triage, remove the ta-bot-triage label and re-apply ta-needs-triage.
⚠️ Some dimensions could not be confidently classified. An engineer should review this issue.