v4.4.0 RC: Scanned QR Send: Receiving wallet does not display received token transaction.

[chrisleewilcox]

Discovered during iOS regression; needs investigation on whether it occurs in Android regression

Send: Receiving wallet does not display received token transaction.

• On Rinkeby network
• On Receiving device: Wallet View ETH selected: Receive: Display QR code
• On Sending device: Wallet View: Scan receiving device QR code
• On Sending device: enter amount and Send
• On Sending device: Transaction for sending tokens to receiving device is displayed
• On Receiving device: Transaction for receiving tokens from sending device is not displayed

Expected: Receiving wallet should show the transaction for receiving tokens.
recording: https://recordit.co/FEk9q4RUJI
txn: 0x85ac8d3730c509b8fb8732a4e22c06d9cc6d4f387383c20b68ec9bd82adf4297 https://rinkeby.etherscan.io/tx/0x1e4165176eb0a2826a87568a5aba4eb5d4d40bcf5366ae2ec5c51a3db39b70ce

[mobularay]

@chrisleewilcox , in discussing with @andrepimenta

• it might take up to 10mins for the transactions to show up; also maybe change network so that the app refreshes (and updates the view)
• is this happening in prod (with both wallets with v4.3.1)? If it is, then not a blocker
• if it's not happening in prod, then it is a blocker

@gantunesr: tagging you for visibility since you've worked on transactions alot in the past

@jpcloureiro ^^^

[jpcloureiro]

@mobularay from my tests I could reproduce the delay on receiving the tx on 4.4.0 & the 4.3.1 from App store.
Although the behaviour is not consistent on every try.

I did some debugging on the Engine.js.refreshTransactionHistory and saw the blockNumber not being updated for more than the delta enforces. Still needs more debugging

[gantunesr]

Some notes about this bug,

• This is not a new bug, therefore, not a blocker.
• I would classify this a Severity 3 - Low and Priority - Medium
• This bug is not QR specific, after the transaction is submitted to the blockchain, it follows the same logic as all transactions in Rinkeby (This network uses the Etherscan API)
• This is likely a controllers bug, we need verify the logic in the following methods,
  • fetchAll
  • handleTransactionFetch
  • etherscanTransactionStateReconciler
  • trimTransactionsForState