Skip to content

Unable to send via QR code of a valid ENS address  #5416

Open
@plasmacorral

Description

@plasmacorral

Description

This came up in testing PR 5191 and at the time was confirmed to exist in production.

If from wallet view, the user taps the QR scan icon in the top right corner and scans a QR code that resolves to a .eth address, nothing happens and the user is returned to wallet view with no error or indication of their failed attempt.

If the user taps "send" from drawer, wallet view, or asset details then taps the QR scan icon within the To: field, and scans a QR code that resolves to a valid ENS address, the following error is presented:
"Unrecognized QR code
Sorry, this QR code is not associated with an account address or a contract address"

This has security implications for users and creates a risk that the user could experience funds loss by sending assets to an incorrect address if they are forced to enter the ENS name through the keyboard.

Technical Details

  • ENS name represented as a QR code is not recognized as a valid address on either iOS or Android v5.12.1 build 1028

Acceptance Criteria

  • User should be able to send to an ENS name by scanning a QR code from wallet view, or from within the send flow via app drawer, wallet view, or asset details.

Scenario: Scan QR from wallet view

  • GIVEN a user is in wallet view
  • WHEN a user taps the QR scan icon on the top right
  • AND the camera opens
  • AND the user scans a QR code that represents a valid ENS name
  • THEN the user should be brought to the "Send to" screen with the ENS name and its resolved address in the to field
  • AND the "Next" CTA should be presented and enabled
  • WHEN the user enters an amount in the "Amount" page
  • AND taps "Next"
  • THEN "Confirm" page is presented
  • AND the ENS name and resolved address appear in the "To:" field
  • AND the "Send" CTA is present and enabled
  • WHEN the user taps "Send"
  • THEN the transaction is broadcast to the network
  • AND the amount specified is sent to the correct address registered to the ENS name

Scenario: Scan QR from send flow

  • GIVEN a user is accessing send flow from app drawer, wallet view or asset details
  • WHEN a user taps "Send"
  • THEN the "Send to" page is opened
  • AND the QR scan icon is presented in the "To:" field
  • WHEN the user taps the QR scan icon in the "To:" field
  • THEN the camera opens
  • WHEN the user scans a QR code that represents a valid ENS name
  • THEN the ENS name and its resolved address should appear in the "To:" field
  • AND the "Next" CTA should be presented and enabled
  • WHEN the user taps "Next"
  • AND the user enters an amount in the "Amount" page
  • AND taps "Next"
  • THEN "Confirm" page is presented
  • AND the ENS name and resolved address appear in the "To:" field
  • AND the "Send" CTA is present and enabled
  • WHEN the user taps "Send"
  • THEN the transaction is broadcast to the network
  • AND the amount specified is sent to the correct address registered to the ENS name

References

  • You can use browser plugin "Offline QR generator" to create a QR for testing

  • Here is a sample QR to metarnask.eth:
    Screenshot 2022-12-20 at 5 11 38 PM

  • Error message when scanned from "To:" field:

Screenshot 2022-12-20 at 5 11 17 PM

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    To be fixed

    Status

    To be triaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions