From bc6cb52281eb4a617e22e3276d08ff3a480e2dc5 Mon Sep 17 00:00:00 2001 From: Cal-L Date: Tue, 8 Apr 2025 16:04:50 -0700 Subject: [PATCH] Add e2e label check --- .github/scripts/check-pr-has-required-labels.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/scripts/check-pr-has-required-labels.ts b/.github/scripts/check-pr-has-required-labels.ts index bc91e6f8ac79..1e2a8df6c2a6 100644 --- a/.github/scripts/check-pr-has-required-labels.ts +++ b/.github/scripts/check-pr-has-required-labels.ts @@ -51,24 +51,28 @@ async function main(): Promise { ]; let hasTeamLabel = false; let hasQALabel = false; - + let hasSmokeE2ELabel = false; // Check pull request has at least required QA label and team label for (const label of pullRequestLabels) { if (label.startsWith('team-') || label === externalContributorLabel.name) { console.log(`PR contains a team label as expected: ${label}`); hasTeamLabel = true; } - if (label.includes('Run Smoke E2E') || label.includes('No QA Needed') || label.includes('QA Passed') ) { + if (label.includes('No QA Needed') || label.includes('QA Passed') ) { console.log(`PR contains a QA label as expected: ${label}`); hasQALabel = true; } + if (label.includes('Run Smoke E2E') || label.includes('No E2E Smoke Needed')) { + console.log(`PR contains a Smoke E2E label as expected: ${label}`); + hasSmokeE2ELabel = true; + } if (preventMergeLabels.includes(label)) { core.setFailed( `PR cannot be merged because it still contains this label: ${label}`, ); process.exit(1); } - if (hasTeamLabel && hasQALabel) { + if (hasTeamLabel && hasQALabel && hasSmokeE2ELabel) { return; } }