fix: restore snap and imported srps when changing password

[montelaidev]

Description

This PR adds the restoration of first party snap accounts and imported srps when changing password.

Changes:

1. added restoreImportedSrp restoreSnapAccounts to Vault.js and updated the change password logic to use these.
2. Added new tests to Vault
3. Fix deadlock that could happen when awaiting a promise in MultichainSnapClient.

Related issues

Fixes: #15233
Resolves: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-208?atlOrigin=eyJpIjoiMmM0MDMzNDRlYzdlNDJmZTg3ODNhMzUzNzlkOWZmZDIiLCJwIjoiaiJ9

Manual testing steps

1. Using a fresh wallet.
2. Create a new solana account
3. Import a private key
4. Import a qr hardware wallet
5. import a ledger wallet
6. Go to settings --> security
7. Go through change password
8. Login to the wallet and see that accounts are still there.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7a14c1b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/402ab50f-d62e-48e4-bed7-6afeb9ee42ed

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9926d8b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a7e9c4f-75b0-414e-992f-5e1e0fcd276f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud