Skip to content

feat: STAKE-1023 add lending withdraw and deposit more buttons #15238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented May 8, 2025

Note: This PR relies on several commits from #15132. Do not merge this PR until the prerequisite PR has been reviewed and merged.


Description

This PR adds the withdraw and deposit more buttons for supported stablecoins.

Related issues

Jira ticket: STAKE-1023: Add Lending "Withdraw" and "Deposit more" buttons

Screenshots

image

Manual testing steps

Prerequisite: Open file, app/components/UI/Earn/constants and change USER_HAS_LENDING_POSITIONS to equal true. The buttons will only appear if the user has existing lending positions. This temp variable simulates this.

  1. From the token list (home screen) click on a supported stablecoin (DAI, USDC, USDT)
  2. On the asset overview page, you should see the withdraw and deposit more buttons
  3. Clicking withdrawal should redirect you to the withdrawal input screen
  4. Clicking deposit more should redirect you to the deposit input screen

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 force-pushed the feat/stake-1023-add-lending-withdraw-and-deposit-more-buttons branch from 97913ee to 36c4044 Compare May 9, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-earn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants