Skip to content

feat: support bitcoin #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 13, 2025
Merged

feat: support bitcoin #15263

merged 9 commits into from
May 13, 2025

Conversation

darioAnongba
Copy link
Contributor

Description

Bump Bitcoin Snap version.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NNT-338

Manual testing steps

  1. Install MM Flask
  2. Create Bitcoin account

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darioAnongba darioAnongba self-assigned this May 9, 2025
@darioAnongba darioAnongba requested review from a team as code owners May 9, 2025 12:10
Copy link
Contributor

github-actions bot commented May 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darioAnongba
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

socket-security bot commented May 9, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bitcoin-wallet-snap@​0.9.0 ⏵ 0.12.1100 +14100100 +2100 +4100

View full report

@darioAnongba darioAnongba added team-accounts No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing labels May 9, 2025
Copy link
Contributor

github-actions bot commented May 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1e5125d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f4f194c-6867-4cdd-bcdb-b5fdad249d32

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@darioAnongba darioAnongba marked this pull request as draft May 9, 2025 12:43
@darioAnongba darioAnongba marked this pull request as ready for review May 9, 2025 12:47
@darioAnongba darioAnongba removed the request for review from a team May 9, 2025 15:46
@darioAnongba darioAnongba requested a review from tommasini May 12, 2025 11:12
@darioAnongba darioAnongba added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit e7f4d24 May 13, 2025
40 checks passed
@darioAnongba darioAnongba deleted the build/bitcoin-snap branch May 13, 2025 09:59
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 Run Smoke E2E Requires smoke E2E testing team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants