Skip to content

fix: switching to solana address in legacy swaps, redirect them to solana swaps UI #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: switching to solana address in legacy swaps, redirect them to solana swaps UI #15273

wants to merge 3 commits into from
+100 −56

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented May 9, 2025 •
edited
Loading

Description

This PR fixes an issue where in Legacy Swaps if you switched to a Solana account, the Legacy Swaps would remain showing you your previous EVM chain tokens.

Now we redirect them to the new Solana Swaps UI,

Related issues

Fixes:

Manual testing steps

  1. Switch to an EVM network
  2. Go to Swaps
  3. Switch account to Solana account
  4. Get redirected to Solana Swaps UI

Screenshots/Recordings

Before

After

Screen.Recording.2025-05-09.at.5.04.14.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review May 9, 2025 21:06
@infiniteflower infiniteflower requested a review from a team as a code owner May 9, 2025 21:06
@infiniteflower infiniteflower changed the title fix: switching to solana address in legacy swaps, redirect them to so… fix: switching to solana address in legacy swaps, redirect them to solana swaps UI May 9, 2025
@infiniteflower infiniteflower added the Run Smoke E2E Requires smoke E2E testing label May 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 768819c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/39f48798-e1c4-41b7-b5fb-f5ba61ee0527

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@infiniteflower infiniteflower added the QA Passed QA testing has been completed and passed label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
QA Passed QA testing has been completed and passed Run Smoke E2E Requires smoke E2E testing team-swaps-and-bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infiniteflower @metamaskbot