Skip to content

feat: Implement network-row component for redesigned transfer transactions #15281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

OGPoyraz
Copy link
Member

Description

This PR implements network-row component for transfer confirmations.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4796

Manual testing steps

Only possible to test it out via setting FEATURE_FLAG_REDESIGNED_TRANSFER to true. This flow is not yet manually QA'ed hence the No QA Needed

Screenshots/Recordings

Before

After

Wallet initiated example
Screenshot 2025-05-12 at 10 43 36

DApp initiated example

Screenshot 2025-05-12 at 10 43 18

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners May 12, 2025 08:47
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. team-confirmations Push issues to confirmations team no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Requires smoke E2E testing labels May 12, 2025
Copy link
Contributor

github-actions bot commented May 12, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0f6d6f3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61e11fc9-fc0d-45a3-a9a8-b51bc3bd2fc5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit 33ae98a May 13, 2025
43 of 44 checks passed
@OGPoyraz OGPoyraz deleted the ogp/4796 branch May 13, 2025 14:40
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.48.0 Issue or pull request that will be included in release 7.48.0 Run Smoke E2E Requires smoke E2E testing team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants