feat(rewards): display benefit company name#30231
Draft
jeremytsng wants to merge 1 commit into
Draft
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Surface the provider/company name on the benefit card and benefit detail page so users can tell at a glance who is offering the benefit, instead of inferring it from the description.
companyNameopposite the title in the header row.BenefitFullView): renderBy {companyName}opposite the remaining-time row.companyNamerenders nothing (no placeholder, no "By ").flex-1, companymax-w-[40%]on the card,max-w-[55%]on the detail) so long names cannot push the title or overflow.Depends on the companion backend change exposing
companyNameonBenefitDto: consensys-vertical-apps/va-mmcx-rewards#560.Changelog
CHANGELOG entry: Added the provider company name to benefit cards and the benefit detail page.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
No company label is rendered on either the card or the detail page.
After
4d 20hon the left,By {companyName}aligned to the right of the same row.Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist