Commit d5110fb
fix: address cursor review findings
- Set streamInactivityTimeoutMs to 6s (above the 5s floor) in the
E2E test so the inactivity timeout actually fires
- Remove redundant giveUp() call in #handleAckTimeout — RemoteManager
is the sole caller via #onGiveUp callback
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 877fb80 commit d5110fb
2 files changed
Lines changed: 7 additions & 6 deletions
File tree
- packages
- kernel-node-runtime/test/e2e
- ocap-kernel/src/remotes/kernel
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| 169 | + | |
| 170 | + | |
169 | 171 | | |
170 | 172 | | |
171 | | - | |
| 173 | + | |
172 | 174 | | |
173 | 175 | | |
174 | 176 | | |
| |||
190 | 192 | | |
191 | 193 | | |
192 | 194 | | |
193 | | - | |
| 195 | + | |
194 | 196 | | |
195 | 197 | | |
196 | | - | |
| 198 | + | |
197 | 199 | | |
198 | 200 | | |
199 | 201 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
380 | | - | |
| 379 | + | |
| 380 | + | |
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
384 | | - | |
385 | 384 | | |
386 | 385 | | |
387 | 386 | | |
| |||
0 commit comments