Skip to content

Commit d26935c

Browse files
committed
Add the extension enablement-run split counts as the canonical triage example in mm-react-compiler-error-triage
1 parent 39d5f8d commit d26935c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

domains/performance/skills/performance/references/mm-react-compiler-error-triage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Compiler diagnostics are **not one bucket**. The logger event's `category` field
2727
- **`category === 'Todo'` → "unsupported."** Syntax or a pattern the compiler *itself* has not implemented yet. There is **no actionable fix on our side** — rewriting working code to appease an unimplemented compiler path is wasted effort and churn. Count these separately, leave the code alone, and re-check after compiler upgrades.
2828
- **Any other category (e.g. `InvalidReact`, `InvalidJS`) → legitimate, actionable.** A real Rules-of-React violation in our code (mutation during render, conditional hooks, side effects in render). Fixing it both unlocks compilation *and* removes a latent correctness bug.
2929

30-
A healthcheck that doesn't make this split is noise: the `Todo` count swamps the actionable list and the team learns to ignore the output. The extension's webpack wrapper makes the split in ~10 lines:
30+
A healthcheck that doesn't make this split is noise: the `Todo` count swamps the actionable list and the team learns to ignore the output. The extension's verbose run at enablement (metamask-extension#38007) is the canonical illustration — of 7,308 files processed: 253 compiled, **31 actionable errors**, **7,024 unsupported** (`Todo`). Without the split that reads as ~7,000 hopeless errors; with it, the team's backlog is 31 files and the rest is the compiler's to burn down across upgrades. The extension's webpack wrapper makes the split in ~10 lines:
3131

3232
```ts
3333
// adapted from metamask-extension development/webpack/utils/loaders/reactCompilerLoaderWrapper.ts

0 commit comments

Comments
 (0)