refactor(recipe-harness): share entrypoint helpers

Author: abretonc7s

domains/agentic/skills/recipe-harness/scripts/lib/cli-common.sh

@@ -0,0 +1,66 @@
+#!/usr/bin/env bash
+# Shared helpers for recipe-harness entrypoints.
+
+valid_adapter_action() {
+  case "${1:-}:${2:-}" in
+    mobile:install|mobile:launch|mobile:live|mobile:verify|mobile:cleanup|extension:install|extension:launch|extension:live|extension:verify|extension:cleanup) return 0 ;;
+    *) return 1 ;;
+  esac
+}
+
+has_arg() {
+  local needle="$1"
+  shift
+  local arg
+  for arg in "$@"; do
+    [ "$arg" = "$needle" ] && return 0
+    case "$arg" in "$needle="*) return 0 ;; esac
+  done
+  return 1
+}
+
+arg_value() {
+  local needle="$1"
+  shift
+  while [ "$#" -gt 0 ]; do
+    case "$1" in
+      "$needle") [ "$#" -ge 2 ] && printf '%s\n' "$2"; return 0 ;;
+      "$needle"=*) printf '%s\n' "${1#*=}"; return 0 ;;
+    esac
+    shift
+  done
+  return 1
+}
+
+is_false() {
+  case "${1:-}" in
+    0|false|FALSE|False|no|NO|No|off|OFF|Off) return 0 ;;
+    *) return 1 ;;
+  esac
+}
+
+cdp_reachable() {
+  local port="$1"
+  command -v curl >/dev/null 2>&1 || return 1
+  curl -fsS --max-time 1 "http://127.0.0.1:${port}/json/version" >/dev/null 2>&1
+}
+
+detect_adapter() {
+  local target="$1"
+  local remote=""
+  remote="$(git -C "$target" config --get remote.origin.url 2>/dev/null || true)"
+  case "$remote" in
+    *metamask-extension*) printf 'extension\n'; return 0 ;;
+    *metamask-mobile*) printf 'mobile\n'; return 0 ;;
+  esac
+
+  if [ -f "$target/development/skills-sync.ts" ] || { [ -d "$target/ui" ] && [ -d "$target/app/scripts" ]; }; then
+    printf 'extension\n'
+    return 0
+  fi
+  if [ -f "$target/scripts/skills-sync.mts" ] || { [ -d "$target/ios" ] && [ -d "$target/android" ] && [ -d "$target/app/core" ]; }; then
+    printf 'mobile\n'
+    return 0
+  fi
+  return 1
+}

domains/agentic/skills/recipe-harness/scripts/recipe-harness

@@ -45,6 +45,8 @@ log() { printf '[%s] %s\n' "$SCRIPT_NAME" "$*" >&2; }
 fail() { printf '[%s] ERROR: %s\n' "$SCRIPT_NAME" "$*" >&2; exit 1; }
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck disable=SC1091
+. "$SCRIPT_DIR/lib/cli-common.sh"
 RECIPE_HARNESS="$SCRIPT_DIR/recipe-harness.sh"
 [ -x "$RECIPE_HARNESS" ] || fail "missing recipe-harness.sh next to $0"
 
@@ -93,27 +95,6 @@ case "${1:-}" in
     done
     TARGET="$(cd "$TARGET" && pwd)"
 
-    detect_adapter() {
-      local target="$1"
-      local remote=""
-      remote="$(git -C "$target" config --get remote.origin.url 2>/dev/null || true)"
-      case "$remote" in
-        *metamask-extension*) printf 'extension\n'; return 0 ;;
-        *metamask-mobile*) printf 'mobile\n'; return 0 ;;
-      esac
-
-      # Repo-shape fallback for worktrees/clones with unusual remote names.
-      if [ -f "$target/development/skills-sync.ts" ] || { [ -d "$target/ui" ] && [ -d "$target/app/scripts" ]; }; then
-        printf 'extension\n'
-        return 0
-      fi
-      if [ -f "$target/scripts/skills-sync.mts" ] || { [ -d "$target/ios" ] && [ -d "$target/android" ] && [ -d "$target/app/core" ]; }; then
-        printf 'mobile\n'
-        return 0
-      fi
-      return 1
-    }
-
     if [ -z "$ADAPTER" ]; then
       ADAPTER="$(detect_adapter "$TARGET")" || fail "could not detect MetaMask repo type for $TARGET; pass --adapter mobile or --adapter extension"
     fi
@@ -126,10 +107,10 @@ case "${1:-}" in
     ;;
 esac
 
-case "$ADAPTER:$ACTION" in
-  mobile:install|mobile:launch|mobile:live|mobile:verify|mobile:cleanup|extension:install|extension:launch|extension:live|extension:verify|extension:cleanup) ;;
-  *) usage >&2; fail "unsupported adapter/action: ${ADAPTER:-?}/${ACTION:-?}" ;;
-esac
+if ! valid_adapter_action "$ADAPTER" "$ACTION"; then
+  usage >&2
+  fail "unsupported adapter/action: ${ADAPTER:-?}/${ACTION:-?}"
+fi
 
 # In explicit form, TARGET may not be set. Try to discover it from args for display only.
 if [ -z "${TARGET:-}" ]; then
@@ -157,28 +138,6 @@ esac
 
 log "$VERB $ADAPTER recipe harness"
 log "Target: $TARGET"
-has_arg() {
-  local needle="$1"
-  shift
-  for arg in "$@"; do
-    [ "$arg" = "$needle" ] && return 0
-    case "$arg" in "$needle="*) return 0 ;; esac
-  done
-  return 1
-}
-
-cdp_reachable() {
-  local port="$1"
-  command -v curl >/dev/null 2>&1 || return 1
-  curl -fsS --max-time 1 "http://127.0.0.1:${port}/json/version" >/dev/null 2>&1
-}
-
-is_false() {
-  case "${1:-}" in
-    0|false|FALSE|False|no|NO|No|off|OFF|Off) return 0 ;;
-    *) return 1 ;;
-  esac
-}
 
 # shellcheck disable=SC1091
 . "$SCRIPT_DIR/lib/json-field.sh"

domains/agentic/skills/recipe-harness/scripts/recipe-harness.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+# Backward-compatible low-level dispatcher. Prefer scripts/recipe-harness for human use.
 set -euo pipefail
 
 usage() {
@@ -18,28 +19,6 @@ Examples:
 EOF
 }
 
-has_arg() {
-  local needle="$1"
-  shift
-  local arg
-  for arg in "$@"; do
-    [ "$arg" = "$needle" ] && return 0
-  done
-  return 1
-}
-
-arg_value() {
-  local needle="$1"
-  shift
-  while [ "$#" -gt 0 ]; do
-    if [ "$1" = "$needle" ]; then
-      [ "$#" -ge 2 ] && printf '%s\n' "$2"
-      return 0
-    fi
-    shift
-  done
-  return 1
-}
 
 if [ "$#" -lt 2 ]; then
   usage >&2
@@ -51,18 +30,17 @@ ACTION="$2"
 shift 2
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck disable=SC1091
+. "$SCRIPT_DIR/lib/cli-common.sh"
 SKILL_DIR="$(cd "${SCRIPT_DIR}/.." && pwd)"
 ADAPTER_SCRIPT="${SKILL_DIR}/adapters/${ADAPTER}/scripts/${ACTION}.sh"
 # shellcheck disable=SC1091
 . "$SCRIPT_DIR/lib/json-field.sh"
 
-case "${ADAPTER}:${ACTION}" in
-  mobile:install|mobile:launch|mobile:live|mobile:verify|mobile:cleanup|extension:install|extension:launch|extension:live|extension:verify|extension:cleanup) ;;
-  *)
-    usage >&2
-    exit 2
-    ;;
-esac
+if ! valid_adapter_action "$ADAPTER" "$ACTION"; then
+  usage >&2
+  exit 2
+fi
 
 if [ ! -x "$ADAPTER_SCRIPT" ]; then
   echo "Missing adapter script: $ADAPTER_SCRIPT" >&2