Normalize tests a little bit

Author: jeffsmale90

packages/7715-permission-types/test/permissions/caveats/erc20TokenAllowance.test.ts

@@ -97,9 +97,10 @@ describe('erc20-token-allowance decoder config', () => {
 
     it('validateAndDecodeData decodes valid allowance terms', () => {
       expect(
-        decoder.validateAndDecodeData(makeCaveats(VALID_ALLOWANCE_TERMS), {
-          ...decoder.contractAddresses,
-        }),
+        decoder.validateAndDecodeData(
+          makeCaveats(VALID_ALLOWANCE_TERMS),
+          decoder.contractAddresses,
+        ),
       ).toStrictEqual({
         tokenAddress: `0x${TOKEN_ADDRESS_HEX}`,
         allowanceAmount: `0x${ALLOWANCE_AMOUNT_HEX}`,
@@ -131,6 +132,20 @@ describe('erc20-token-allowance decoder config', () => {
       );
     });
 
+    it('validateAndDecodeData rejects when startTime is zero', () => {
+      const invalidTerms =
+        `0x${TOKEN_ADDRESS_HEX}${ALLOWANCE_AMOUNT_HEX}${UINT256_MAX.slice(2)}${toWord(0)}` as Hex;
+
+      expect(() =>
+        decoder.validateAndDecodeData(
+          makeCaveats(invalidTerms),
+          decoder.contractAddresses,
+        ),
+      ).toThrow(
+        'Invalid erc20-token-allowance terms: startTime must be a positive number',
+      );
+    });
+
     it('validateAndDecodeData rejects zero allowanceAmount', () => {
       const zeroAllowanceAmount = '0'.repeat(64);
       const invalidTerms =

packages/7715-permission-types/test/permissions/caveats/erc20TokenPeriodic.test.ts

@@ -16,6 +16,7 @@ import {
   MAX_PERIOD_DURATION,
   ZERO_32_BYTES,
 } from '../../../src/permissions/utils';
+import { toWord } from '../../test-utils';
 
 describe('erc20-token-periodic decoder config', () => {
   const chainId = CHAIN_ID.sepolia;
@@ -46,9 +47,9 @@ describe('erc20-token-periodic decoder config', () => {
     periodDuration?: number;
     startDate?: number;
   } = {}): Hex => {
-    const periodAmountHex = periodAmount.toString(16).padStart(64, '0');
-    const periodDurationHex = periodDuration.toString(16).padStart(64, '0');
-    const startDateHex = startDate.toString(16).padStart(64, '0');
+    const periodAmountHex = toWord(periodAmount);
+    const periodDurationHex = toWord(periodDuration);
+    const startDateHex = toWord(startDate);
 
     return `${tokenAddress}${periodAmountHex}${periodDurationHex}${startDateHex}`;
   };
@@ -154,6 +155,17 @@ describe('erc20-token-periodic decoder config', () => {
       );
     });
 
+    it('validateAndDecodeData rejects when startTime is zero', () => {
+      expect(() =>
+        decoder.validateAndDecodeData(
+          makeCaveats(makeTerms({ startDate: 0 })),
+          decoder.contractAddresses,
+        ),
+      ).toThrow(
+        'Invalid erc20-token-periodic terms: startTime must be a positive number',
+      );
+    });
+
     it('validateAndDecodeData rejects when periodDuration exceeds MAX_PERIOD_DURATION', () => {
       expect(() =>
         decoder.validateAndDecodeData(

packages/7715-permission-types/test/permissions/caveats/nativeTokenAllowance.test.ts

@@ -130,6 +130,20 @@ describe('native-token-allowance decoder config', () => {
       );
     });
 
+    it('validateAndDecodeData rejects when startTime is zero', () => {
+      const invalidTerms =
+        `0x${ALLOWANCE_AMOUNT_HEX}${UINT256_MAX.slice(2)}${toWord(0)}` as Hex;
+
+      expect(() =>
+        decoder.validateAndDecodeData(
+          makeCaveats(invalidTerms),
+          decoder.contractAddresses,
+        ),
+      ).toThrow(
+        'Invalid native-token-allowance terms: startTime must be a positive number',
+      );
+    });
+
     it('validateAndDecodeData rejects zero allowanceAmount', () => {
       const zeroAllowanceAmount = '0'.repeat(64);
       const invalidTerms =

packages/7715-permission-types/test/permissions/caveats/nativeTokenPeriodic.test.ts

@@ -144,6 +144,17 @@ describe('native-token-periodic decoder config', () => {
       );
     });
 
+    it('validateAndDecodeData rejects when startTime is zero', () => {
+      expect(() =>
+        decoder.validateAndDecodeData(
+          makeCaveats(makeTerms({ startDate: 0 })),
+          decoder.contractAddresses,
+        ),
+      ).toThrow(
+        'Invalid native-token-periodic terms: startTime must be a positive number',
+      );
+    });
+
     it('validateAndDecodeData rejects when periodDuration exceeds MAX_PERIOD_DURATION', () => {
       expect(() =>
         decoder.validateAndDecodeData(