refactor(e2e): remove build step from CI and improve dependency polling logic, remove explicit turbo cache dir

Author: jeffsmale90

.github/workflows/end-to-end-tests.yml

@@ -47,10 +47,5 @@ jobs:
       - name: Install Yarn dependencies
         run: yarn install
 
-      - name: Run build
-        run: yarn build
-        env:
-          NODE_ENV: production
-
       - name: Run end-to-end tests
         run: yarn test:e2e

package.json

@@ -13,8 +13,8 @@
   ],
   "scripts": {
     "allow-scripts": "echo 'n/a'",
-    "build": "turbo build --cache-dir=.turbo",
-    "build:packages": "turbo run build --cache-dir=.turbo --filter='!./packages/delegator-e2e'",
+    "build": "turbo build",
+    "build:packages": "turbo run build --filter='!./packages/delegator-e2e'",
     "changelog:update": "turbo run changelog:update --filter='!./packages/delegator-e2e'",
     "changelog:validate": "turbo run changelog:validate --filter='!./packages/delegator-e2e'",
     "clean": "turbo clean",

packages/delegator-e2e/src/await-dependencies.ts

@@ -24,7 +24,7 @@ const waitFor = async (name: string, url: string) => {
   });
 
   do {
-    if (!isAvailable) {
+    if (isAvailable !== undefined) {
       // Only add a delay if it's not the first time
       await new Promise((resolve) => setTimeout(resolve, POLL_INTERVAL_MS));
     }
@@ -62,12 +62,13 @@ const deployEnvironment = async () => {
 
 (async () => {
   await waitFor('Blockchain node', nodeUrl);
+  const waitingForDependencies = Promise.all([
+    waitFor('Bundler', bundlerUrl),
+    waitFor('Mock paymaster', paymasterUrl),
+  ]);
 
   const environment = await deployEnvironment();
   await writeFile('./.gator-env.json', JSON.stringify(environment, null, 2));
 
-  await Promise.all([
-    waitFor('Bundler', bundlerUrl),
-    waitFor('Mock paymaster', paymasterUrl),
-  ]);
+  await waitingForDependencies;
 })();