fix approval revocation reserved-bit messaging

Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com>

Author: cursoragent

packages/delegation-core/src/caveats/approvalRevocationEnforcer.ts

@@ -107,16 +107,16 @@ function termsToMask(terms: ApprovalRevocationTerms): number {
 }
 
 /**
- * Parses a validated 1..7 bitmask into {@link ApprovalRevocationTerms}.
+ * Parses a validated 1..63 bitmask into {@link ApprovalRevocationTerms}.
  *
- * @param mask - Integer byte value; only bits 0-2 may be set, and at least one must be set.
+ * @param mask - Integer byte value; only bits 0-5 may be set, and at least one must be set.
  * @returns Flag object for encoding/decoding.
  * @throws Error if reserved bits are set or the mask is zero.
  */
 function maskToTerms(mask: number): ApprovalRevocationTerms {
   if (mask > ALLOWED_APPROVAL_REVOCATION_MAX_MASK) {
     throw new Error(
-      'Invalid ApprovalRevocation terms: reserved bits must be zero (only bits 0-2 are defined)',
+      'Invalid ApprovalRevocation terms: reserved bits must be zero (only bits 0-5 are defined)',
     );
   }
 

packages/delegation-core/test/caveats/approvalRevocationEnforcer.test.ts

@@ -32,6 +32,9 @@ const ALL_VALID_TERM_SETS: ApprovalRevocationTerms[] = Array.from(
   },
 );
 
+const RESERVED_BITS_ERROR =
+  'Invalid ApprovalRevocation terms: reserved bits must be zero (only bits 0-5 are defined)';
+
 describe('ApprovalRevocationEnforcer', () => {
   describe('createApprovalRevocationTerms', () => {
     const BYTE_LEN = 1;
@@ -184,13 +187,13 @@ describe('ApprovalRevocationEnforcer', () => {
 
     it('throws when reserved bits are set on-chain', () => {
       expect(() => decodeApprovalRevocationTerms('0x40')).toThrow(
-        'reserved bits must be zero',
+        RESERVED_BITS_ERROR,
       );
       expect(() => decodeApprovalRevocationTerms('0x80')).toThrow(
-        'reserved bits must be zero',
+        RESERVED_BITS_ERROR,
       );
       expect(() => decodeApprovalRevocationTerms('0xff')).toThrow(
-        'reserved bits must be zero',
+        RESERVED_BITS_ERROR,
       );
     });